From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Jonathan Tan <jonathantanmy@google.com>, git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)
Date: Fri, 29 Jun 2018 12:51:19 -0700 [thread overview]
Message-ID: <xmqqk1qhtlqg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGZ79kbKrDu8iW+867c73OMhgqEYA1H3-zQpejxq5jMMNRb2Bg@mail.gmail.com> (Stefan Beller's message of "Thu, 28 Jun 2018 15:42:57 -0700")
Stefan Beller <sbeller@google.com> writes:
>> * jt/remove-pack-bitmap-global (2018-06-21) 2 commits
>> - pack-bitmap: add free function
>> - pack-bitmap: remove bitmap_git global variable
>>
>> The effort to move globals to per-repository in-core structure
>> continues.
>
> This is mostly done, though Peff seems to expect a reroll with
> clarification on how the series is structured?
> https://public-inbox.org/git/20180611211033.GB26235@sigill.intra.peff.net/
That one has been resolved by squashing the updated log message in,
I think, so we should be able to merge it down.
>> * sb/submodule-move-head-error-msg (2018-06-25) 1 commit
>> - submodule.c: report the submodule that an error occurs in
>>
>> Needs a reroll.
>> cf. <20180622081713.5360-1-szeder.dev@gmail.com>
>
> https://public-inbox.org/git/xmqqmuviq2n7.fsf@gitster-ct.c.googlers.com/
>
> suggests that you applied that change and a reroll would not be needed.
Yup, I forgot about that one. Thanks.
> It is easy to quantify how often we are bitten by code churn
> (that you call useless here); and very hard to quantify bugs
By definition, churn is useless. Useful ones are refactoring ;-).
And when you do want to operate on _the_ single in-core instance,
not having to say &the_index in the argument and use $foo_cache()
function does *not* become a source of "bugs". It just saves
typing, and turning it to $foo_index(&the_index,...) does *not* make
it less error prone.
>> * sb/diff-color-move-more (2018-06-25) 11 commits
>> - diff: fix a sparse 'dubious one-bit signed bitfield' error
>> - SQUASH??? t/4015 GETTEXT_POISON emergency fix
>> - SQUASH????? Documentation breakage emergency fix
> [...]
>>
>> "git diff --color-moved" feature has further been tweaked.
>>
>> Needs to be cleaned-up with various fix-up bits applied inline.
>
> I'll resend with those squashes and another (test-)fix SZEDER
> mentioned soon.
The interdiff of the topic looked alright. Thanks.
next prev parent reply other threads:[~2018-06-29 19:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:40 What's cooking in git.git (Jun 2018, #07; Thu, 28) Junio C Hamano
2018-06-28 22:42 ` Stefan Beller
2018-06-29 13:55 ` Derrick Stolee
2018-06-29 19:51 ` Junio C Hamano [this message]
2018-06-29 11:10 ` ag/rebase-i-append-todo-help, was " Alban Gruin
2018-06-29 21:04 ` Ævar Arnfjörð Bjarmason
2018-07-03 11:44 ` as/safecrlf-quiet-fix, was " Johannes Schindelin
2018-07-03 17:59 ` Junio C Hamano
2018-07-04 9:25 ` Johannes Schindelin
2018-07-06 15:38 ` Junio C Hamano
2018-07-03 11:46 ` jh/partial-clone, " Johannes Schindelin
2018-07-03 11:54 ` as/sequencer-customizable-comment-char, " Johannes Schindelin
2018-07-03 12:52 ` ag/rebase-i-rewrite-todo, " Johannes Schindelin
2018-07-06 17:50 ` Junio C Hamano
2018-07-06 19:21 ` Johannes Schindelin
2018-07-06 19:40 ` Junio C Hamano
2018-07-06 22:38 ` Johannes Schindelin
2018-07-03 13:05 ` js/branch-diff, " Johannes Schindelin
2018-07-03 22:12 ` Junio C Hamano
2018-07-04 9:27 ` Johannes Schindelin
2018-07-03 18:30 ` Elijah Newren
2018-07-03 18:33 ` Eric Sunshine
2018-07-09 17:31 ` Jonathan Tan
2018-07-09 18:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1qhtlqg.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).