git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>, Aaron Schrab <aaron@schrab.com>
Cc: git@vger.kernel.org
Subject: as/sequencer-customizable-comment-char, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)
Date: Tue, 3 Jul 2018 13:54:06 +0200 (DST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1807031353520.75@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqd0wawpwy.fsf@gitster-ct.c.googlers.com>

Hi Junio & Aaron,

On Thu, 28 Jun 2018, Junio C Hamano wrote:

> * as/sequencer-customizable-comment-char (2018-06-28) 1 commit
>  - sequencer: use configured comment character
> 
>  Honor core.commentchar when preparing the list of commits to replay
>  in "rebase -i".

As per
https://public-inbox.org/git/nycvar.QRO.7.76.6.1806291607501.74@tvgsbejvaqbjf.bet/
I am inclined to ask for a "v2" (i.e. second iteration of the patch, see
e.g.
https://github.com/git-for-windows/git/blob/master/CONTRIBUTING.md#submit-the-patch
where it talks about submitting an "nth version") that adds an explanation
to the commit message why the "auto" value is handled correctly by this
patch, as this is not really obvious from reading the diff alone.

After that change, I think this is ready for `next`.

Ciao,
Dscho

  parent reply	other threads:[~2018-07-03 11:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 21:40 What's cooking in git.git (Jun 2018, #07; Thu, 28) Junio C Hamano
2018-06-28 22:42 ` Stefan Beller
2018-06-29 13:55   ` Derrick Stolee
2018-06-29 19:51   ` Junio C Hamano
2018-06-29 11:10 ` ag/rebase-i-append-todo-help, was " Alban Gruin
2018-06-29 21:04 ` Ævar Arnfjörð Bjarmason
2018-07-03 11:44 ` as/safecrlf-quiet-fix, was " Johannes Schindelin
2018-07-03 17:59   ` Junio C Hamano
2018-07-04  9:25     ` Johannes Schindelin
2018-07-06 15:38       ` Junio C Hamano
2018-07-03 11:46 ` jh/partial-clone, " Johannes Schindelin
2018-07-03 11:54 ` Johannes Schindelin [this message]
2018-07-03 12:52 ` ag/rebase-i-rewrite-todo, " Johannes Schindelin
2018-07-06 17:50   ` Junio C Hamano
2018-07-06 19:21     ` Johannes Schindelin
2018-07-06 19:40       ` Junio C Hamano
2018-07-06 22:38         ` Johannes Schindelin
2018-07-03 13:05 ` js/branch-diff, " Johannes Schindelin
2018-07-03 22:12   ` Junio C Hamano
2018-07-04  9:27     ` Johannes Schindelin
2018-07-03 18:30 ` Elijah Newren
2018-07-03 18:33   ` Eric Sunshine
2018-07-09 17:31 ` Jonathan Tan
2018-07-09 18:13   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1807031353520.75@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=aaron@schrab.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).