From: Elijah Newren <newren@gmail.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)
Date: Tue, 3 Jul 2018 11:30:59 -0700 [thread overview]
Message-ID: <CABPp-BE=2nzEG=X0Jv3++J3Yo3H0yfJ9vd4pDYYBw5fpzDYc_g@mail.gmail.com> (raw)
In-Reply-To: <xmqqd0wawpwy.fsf@gitster-ct.c.googlers.com>
Hi Derrick,
On Thu, Jun 28, 2018 at 2:40 PM, Junio C Hamano <gitster@pobox.com> wrote:
> * ds/multi-pack-index (2018-06-25) 24 commits
> - midx: clear midx on repack
> - packfile: skip loading index if in multi-pack-index
> - midx: prevent duplicate packfile loads
> - midx: use midx in approximate_object_count
> - midx: use existing midx when writing new one
> - midx: use midx in abbreviation calculations
> - midx: read objects from multi-pack-index
> - midx: prepare midxed_git struct
> - config: create core.multiPackIndex setting
> - midx: write object offsets
> - midx: write object id fanout chunk
> - midx: write object ids in a chunk
> - midx: sort and deduplicate objects from packfiles
> - midx: read pack names into array
> - multi-pack-index: write pack names in chunk
> - multi-pack-index: read packfile list
> - packfile: generalize pack directory list
> - multi-pack-index: expand test data
> - multi-pack-index: load into memory
> - midx: write header information to lockfile
> - multi-pack-index: add 'write' verb
> - multi-pack-index: add builtin
> - multi-pack-index: add format details
> - multi-pack-index: add design document
>
> When there are too many packfiles in a repository (which is not
> recommended), looking up an object in these would require
> consulting many pack .idx files; a new mechanism to have a single
> file that consolidates all of these .idx files is introduced.
pu fails to build for me (with the standard 'make DEVELOPER=1 ...'),
and it appears to come from this series:
midx.c:567:15: error: ‘write_midx_pack_lookup’ defined but not used
[-Werror=unused-function]
static size_t write_midx_pack_lookup(struct hashfile *f,
It looks like the use of this function was removed in v2 of your
series, but the function itself was left behind? Could you take a
look?
Thanks,
Elijah
next prev parent reply other threads:[~2018-07-03 18:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:40 What's cooking in git.git (Jun 2018, #07; Thu, 28) Junio C Hamano
2018-06-28 22:42 ` Stefan Beller
2018-06-29 13:55 ` Derrick Stolee
2018-06-29 19:51 ` Junio C Hamano
2018-06-29 11:10 ` ag/rebase-i-append-todo-help, was " Alban Gruin
2018-06-29 21:04 ` Ævar Arnfjörð Bjarmason
2018-07-03 11:44 ` as/safecrlf-quiet-fix, was " Johannes Schindelin
2018-07-03 17:59 ` Junio C Hamano
2018-07-04 9:25 ` Johannes Schindelin
2018-07-06 15:38 ` Junio C Hamano
2018-07-03 11:46 ` jh/partial-clone, " Johannes Schindelin
2018-07-03 11:54 ` as/sequencer-customizable-comment-char, " Johannes Schindelin
2018-07-03 12:52 ` ag/rebase-i-rewrite-todo, " Johannes Schindelin
2018-07-06 17:50 ` Junio C Hamano
2018-07-06 19:21 ` Johannes Schindelin
2018-07-06 19:40 ` Junio C Hamano
2018-07-06 22:38 ` Johannes Schindelin
2018-07-03 13:05 ` js/branch-diff, " Johannes Schindelin
2018-07-03 22:12 ` Junio C Hamano
2018-07-04 9:27 ` Johannes Schindelin
2018-07-03 18:30 ` Elijah Newren [this message]
2018-07-03 18:33 ` Eric Sunshine
2018-07-09 17:31 ` Jonathan Tan
2018-07-09 18:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BE=2nzEG=X0Jv3++J3Yo3H0yfJ9vd4pDYYBw5fpzDYc_g@mail.gmail.com' \
--to=newren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).