From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alban Gruin <alban.gruin@gmail.com>, git@vger.kernel.org
Subject: Re: ag/rebase-i-rewrite-todo, was Re: What's cooking in git.git (Jun 2018, #07; Thu, 28)
Date: Sat, 7 Jul 2018 00:38:09 +0200 (DST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1807070035210.75@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqwou8jgp5.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Fri, 6 Jul 2018, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Of course, at that point I will have to look through those 7 patches
> > again, if only to verify that yes, they are still the same.
>
> That is something the patch author must help the reviewer with, no?
>
> Have uncontroversial stuff early in the series, concentrate on
> stabilizing them before moving on to shiny new toys, then mark them
> "unchanged since the last round" after three dashes when sending a
> reroll to update later parts of the series that are in flux. After
> a few rounds, it may become apparent to reviewers that these early
> parts can stand on their own merit as a separate series, on top of
> which the remaining patches can build as a separate (sub)topic, at
> which time we may have two or more topics, among which the early one
> that has become stable may already be 'next'.
Okay, I give up. I tried to show you that I thought that Alban's
partitioning made sense on its own, that they could (and should) stabilize
independently, even if they technically build on one another. In fact, it
was I who suggested to keep them in bite-sized patch series. And you
simply disagree from your maintaining point of view, and I violently
disagree with your decision from the reviewer's point of view.
In the end, you win.
Dscho
next prev parent reply other threads:[~2018-07-06 22:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:40 What's cooking in git.git (Jun 2018, #07; Thu, 28) Junio C Hamano
2018-06-28 22:42 ` Stefan Beller
2018-06-29 13:55 ` Derrick Stolee
2018-06-29 19:51 ` Junio C Hamano
2018-06-29 11:10 ` ag/rebase-i-append-todo-help, was " Alban Gruin
2018-06-29 21:04 ` Ævar Arnfjörð Bjarmason
2018-07-03 11:44 ` as/safecrlf-quiet-fix, was " Johannes Schindelin
2018-07-03 17:59 ` Junio C Hamano
2018-07-04 9:25 ` Johannes Schindelin
2018-07-06 15:38 ` Junio C Hamano
2018-07-03 11:46 ` jh/partial-clone, " Johannes Schindelin
2018-07-03 11:54 ` as/sequencer-customizable-comment-char, " Johannes Schindelin
2018-07-03 12:52 ` ag/rebase-i-rewrite-todo, " Johannes Schindelin
2018-07-06 17:50 ` Junio C Hamano
2018-07-06 19:21 ` Johannes Schindelin
2018-07-06 19:40 ` Junio C Hamano
2018-07-06 22:38 ` Johannes Schindelin [this message]
2018-07-03 13:05 ` js/branch-diff, " Johannes Schindelin
2018-07-03 22:12 ` Junio C Hamano
2018-07-04 9:27 ` Johannes Schindelin
2018-07-03 18:30 ` Elijah Newren
2018-07-03 18:33 ` Eric Sunshine
2018-07-09 17:31 ` Jonathan Tan
2018-07-09 18:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1807070035210.75@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).