From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Jeff King <peff@peff.net>, Jiang Xin <zhiyou.jx@alibaba-inc.com>,
Mickey Endito <mickey.endito.2323@protonmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH] t5582: remove spurious 'cd "$D"' line
Date: Mon, 30 Aug 2021 09:42:03 -0700 [thread overview]
Message-ID: <xmqqilzm6g10.fsf@gitster.g> (raw)
In-Reply-To: <20210828094726.GG2257957@szeder.dev> ("SZEDER Gábor"'s message of "Sat, 28 Aug 2021 11:47:26 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> On Wed, Aug 25, 2021 at 09:12:37AM -0700, Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:
>>
>> > Hmm. I think that one is different, in that the "cd" is not redundant,
>> > but wrong. But it turns out not to matter to the test. ;)
>>
>> Funny.
>>
>> We are lucky because 'cd ""' stays in the same repository as the
>> current one and not to a random place,
>
> Actually, the results of 'cd ""' are unspecified, though most shells
> do as you said. Do we want something like this?
I doubt it, as the root issue is not "cd" but "$D" and other
variables that we use before setting.
I wonder how close our test suite is for being "set -u" clean.
Running our tests under "set -u" may not be a bad endpoint, but
only if we can get there without too much pain.
Thanks.
next prev parent reply other threads:[~2021-08-30 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 20:12 [PATCH] t5582: remove spurious 'cd "$D"' line Mickey Endito
2021-08-23 23:32 ` Junio C Hamano
2021-08-24 18:59 ` SZEDER Gábor
2021-08-24 21:10 ` Junio C Hamano
2021-08-25 1:35 ` Jeff King
2021-08-25 16:12 ` Junio C Hamano
2021-08-28 9:47 ` SZEDER Gábor
2021-08-30 16:42 ` Junio C Hamano [this message]
2021-08-30 18:58 ` Jeff King
2021-08-30 19:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilzm6g10.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=mickey.endito.2323@protonmail.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).