From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 03F3C1F8C6 for ; Mon, 30 Aug 2021 16:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237710AbhH3QnC (ORCPT ); Mon, 30 Aug 2021 12:43:02 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56410 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237049AbhH3QnC (ORCPT ); Mon, 30 Aug 2021 12:43:02 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 538311666A9; Mon, 30 Aug 2021 12:42:08 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=ZQG7tXaOU4/C 8M+Z2dyAL0H1unELYaW/CAL1qoR6LsA=; b=RN1Hcq+20AcPtzTt2/3eQLcPo76Q tLaWU1ar6KZvTxyUHpSDSWSqSpBbFp2wWddzSwofvvQYwIIWVys5Buu/Nbs3rZWU K8tZKFQOxHl1yB0F8sFaD2aDpVZssRf0cSjxqLVYYw0PfShy9LBLc1AwCNTiYV+i +vyHjwv78BG+EgM= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 4C0691666A8; Mon, 30 Aug 2021 12:42:08 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.116.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 969CF1666A7; Mon, 30 Aug 2021 12:42:05 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: SZEDER =?utf-8?Q?G=C3=A1bor?= Cc: Jeff King , Jiang Xin , Mickey Endito , "git@vger.kernel.org" , Jacob Keller Subject: Re: [PATCH] t5582: remove spurious 'cd "$D"' line References: <20210824185942.GE2257957@szeder.dev> <20210828094726.GG2257957@szeder.dev> Date: Mon, 30 Aug 2021 09:42:03 -0700 In-Reply-To: <20210828094726.GG2257957@szeder.dev> ("SZEDER =?utf-8?Q?G?= =?utf-8?Q?=C3=A1bor=22's?= message of "Sat, 28 Aug 2021 11:47:26 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 35B1794C-09B1-11EC-8719-FA11AF6C5138-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org SZEDER G=C3=A1bor writes: > On Wed, Aug 25, 2021 at 09:12:37AM -0700, Junio C Hamano wrote: >> Jeff King writes: >>=20 >> > Hmm. I think that one is different, in that the "cd" is not redundan= t, >> > but wrong. But it turns out not to matter to the test. ;) >>=20 >> Funny.=20 >>=20 >> We are lucky because 'cd ""' stays in the same repository as the >> current one and not to a random place, > > Actually, the results of 'cd ""' are unspecified, though most shells > do as you said. Do we want something like this? I doubt it, as the root issue is not "cd" but "$D" and other variables that we use before setting. I wonder how close our test suite is for being "set -u" clean. Running our tests under "set -u" may not be a bad endpoint, but only if we can get there without too much pain. Thanks.