From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Jiang Xin" <zhiyou.jx@alibaba-inc.com>,
"Mickey Endito" <mickey.endito.2323@protonmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Jacob Keller" <jacob.keller@gmail.com>
Subject: Re: [PATCH] t5582: remove spurious 'cd "$D"' line
Date: Mon, 30 Aug 2021 12:51:58 -0700 [thread overview]
Message-ID: <xmqqwno23e3l.fsf@gitster.g> (raw)
In-Reply-To: <YS0qbgQhRP6XI7aj@coredump.intra.peff.net> (Jeff King's message of "Mon, 30 Aug 2021 14:58:54 -0400")
Jeff King <peff@peff.net> writes:
> Just throwing "set -u" at the top of test-lib.sh shows many issues:
>
> - we don't initialize some known variables, like say, verbose_only. It
> might be reasonable to have a big list of:
>
> verbose_only=
> verbose=
>
> etc. That would probably be an improvement, though a slight
> maintenance burden.
>
> : ${GIT_TEST_CMP:=}
>
> near the top of the script to pre-declare all such variables.
These two are sensible clean-up, I would think, whether we aim to
achieve "set -u" cleanness. The original issue triggered this
thread was about $D that can be confused by a leaked environment
variable, but these "known variables" that are not assigned to in
the early part of the tests are inviting similar troubles.
Thanks.
prev parent reply other threads:[~2021-08-30 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 20:12 [PATCH] t5582: remove spurious 'cd "$D"' line Mickey Endito
2021-08-23 23:32 ` Junio C Hamano
2021-08-24 18:59 ` SZEDER Gábor
2021-08-24 21:10 ` Junio C Hamano
2021-08-25 1:35 ` Jeff King
2021-08-25 16:12 ` Junio C Hamano
2021-08-28 9:47 ` SZEDER Gábor
2021-08-30 16:42 ` Junio C Hamano
2021-08-30 18:58 ` Jeff King
2021-08-30 19:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwno23e3l.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=mickey.endito.2323@protonmail.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).