git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Jiang Xin" <zhiyou.jx@alibaba-inc.com>,
	"Mickey Endito" <mickey.endito.2323@protonmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"Jacob Keller" <jacob.keller@gmail.com>
Subject: Re: [PATCH] t5582: remove spurious 'cd "$D"' line
Date: Wed, 25 Aug 2021 09:12:37 -0700	[thread overview]
Message-ID: <xmqqsfyxjyfe.fsf@gitster.g> (raw)
In-Reply-To: <YSWeeEgzCCT/3kxR@coredump.intra.peff.net> (Jeff King's message of "Tue, 24 Aug 2021 21:35:52 -0400")

Jeff King <peff@peff.net> writes:

> Hmm. I think that one is different, in that the "cd" is not redundant,
> but wrong. But it turns out not to matter to the test. ;)

Funny. 

We are lucky because 'cd ""' stays in the same repository as the
current one and not to a random place, and because the current one
happens to have no pack and running the command in a repository
without any pack is what the test wants to do anyway.

Thanks, will queue.


> diff --git a/t/t5323-pack-redundant.sh b/t/t5323-pack-redundant.sh
> index 8b01793845..8dbbcc5e51 100755
> --- a/t/t5323-pack-redundant.sh
> +++ b/t/t5323-pack-redundant.sh
> @@ -114,9 +114,9 @@ test_expect_success 'setup main repo' '
>  	create_commits_in "$main_repo" A B C D E F G H I J K L M N O P Q R
>  '
>  
> -test_expect_success 'master: pack-redundant works with no packfile' '
> +test_expect_success 'main: pack-redundant works with no packfile' '
>  	(
> -		cd "$master_repo" &&
> +		cd "$main_repo" &&
>  		cat >expect <<-EOF &&
>  			fatal: Zero packs found!
>  			EOF

  reply	other threads:[~2021-08-25 16:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 20:12 [PATCH] t5582: remove spurious 'cd "$D"' line Mickey Endito
2021-08-23 23:32 ` Junio C Hamano
2021-08-24 18:59   ` SZEDER Gábor
2021-08-24 21:10     ` Junio C Hamano
2021-08-25  1:35     ` Jeff King
2021-08-25 16:12       ` Junio C Hamano [this message]
2021-08-28  9:47         ` SZEDER Gábor
2021-08-30 16:42           ` Junio C Hamano
2021-08-30 18:58             ` Jeff King
2021-08-30 19:51               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqsfyxjyfe.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    --cc=mickey.endito.2323@protonmail.com \
    --cc=peff@peff.net \
    --cc=szeder.dev@gmail.com \
    --cc=zhiyou.jx@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).