From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.de>
Cc: git@vger.kernel.org
Subject: Re: [RFC 1/3] mailinfo: extract patch series id
Date: Tue, 14 Nov 2017 14:47:52 +0900 [thread overview]
Message-ID: <xmqqfu9h4div.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <2252b046-a608-b2aa-d67a-8f7e95fe2dbc@suse.de> (Nicolas Morey-Chaisemartin's message of "Mon, 13 Nov 2017 18:13:32 +0100")
Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.de> writes:
> Extract the patch ID and series length from the [PATCH N/M]
> prefix in the mail header
>
> Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
> ---
> mailinfo.c | 35 +++++++++++++++++++++++++++++++++++
> mailinfo.h | 2 ++
> 2 files changed, 37 insertions(+)
As JTan already mentioned, relying on a substring "PATCH" may not be
very reliable, and trying to locate "%d/%d]" feels like a better
approach.
cleanup_subject() is called only when keep_subject is false, so this
code will not trigger in that case at all. Is this intended?
I would have expected that a new helper function would be written,
without changing existing helpers like cleanup_subject(), and that
new helper gets called by handle_info() after output_header_lines()
helper is called for the "Subject".
Whenever mailinfo learns to glean a new useful piece of information,
it should be made available to scripts that run "git mailinfo", too.
Perhaps show something like
PatchNumber: 1
TotalPatches: 3
at the end of handle_info() to mi->output? I do not think existing
tools mind too much, even if we added a for-debug output e.g.
RawSubject: [RFC 1/3] mailinfo: extract patch series id
to the output.
next prev parent reply other threads:[~2017-11-14 5:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 10:24 [RFC] cover-at-tip Nicolas Morey-Chaisemartin
2017-11-10 15:37 ` Nicolas Morey-Chaisemartin
2017-11-10 18:22 ` Junio C Hamano
2017-11-13 7:58 ` Nicolas Morey-Chaisemartin
2017-11-13 9:48 ` Junio C Hamano
2017-11-13 10:30 ` Junio C Hamano
2017-11-13 10:48 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 0/3] Add support for --cover-at-tip Nicolas Morey-Chaisemartin
2017-11-13 19:40 ` Jonathan Tan
2017-11-13 19:53 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 1/3] mailinfo: extract patch series id Nicolas Morey-Chaisemartin
2017-11-14 5:47 ` Junio C Hamano [this message]
2017-11-14 9:10 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 2/3] am: semi working --cover-at-tip Nicolas Morey-Chaisemartin
2017-11-14 6:00 ` Junio C Hamano
2017-11-14 9:17 ` Nicolas Morey-Chaisemartin
2017-11-16 16:21 ` Nicolas Morey-Chaisemartin
2017-11-17 1:54 ` Junio C Hamano
2017-11-13 17:13 ` [RFC 3/3] log: add an option to generate cover letter from a branch tip Nicolas Morey-Chaisemartin
2017-11-14 6:14 ` Junio C Hamano
2017-11-14 9:28 ` Nicolas Morey-Chaisemartin
2017-11-14 13:05 ` Junio C Hamano
2017-11-14 13:40 ` Nicolas Morey-Chaisemartin
2017-11-14 14:52 ` Junio C Hamano
2017-11-10 18:28 ` [RFC] cover-at-tip Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfu9h4div.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=NMoreyChaisemartin@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).