From: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.de>
To: git@vger.kernel.org
Subject: [RFC 1/3] mailinfo: extract patch series id
Date: Mon, 13 Nov 2017 18:13:32 +0100 [thread overview]
Message-ID: <2252b046-a608-b2aa-d67a-8f7e95fe2dbc@suse.de> (raw)
In-Reply-To: <xmqqbmk68o9d.fsf@gitster.mtv.corp.google.com>
Extract the patch ID and series length from the [PATCH N/M]
prefix in the mail header
Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
mailinfo.c | 35 +++++++++++++++++++++++++++++++++++
mailinfo.h | 2 ++
2 files changed, 37 insertions(+)
diff --git a/mailinfo.c b/mailinfo.c
index a89db22ab..2ab9d446d 100644
--- a/mailinfo.c
+++ b/mailinfo.c
@@ -308,6 +308,39 @@ static void cleanup_subject(struct mailinfo *mi, struct strbuf *subject)
if (!pos)
break;
remove = pos - subject->buf + at + 1;
+ if (7 <= remove &&
+ memmem(subject->buf + at, remove, "PATCH", 5)){
+ /*
+ * Look for a N/M series identifier at
+ * the end of the brackets
+ */
+ int is_series = 1;
+ int ret, num, total;
+ int pt = at + remove - 2;
+
+ if (!isdigit(subject->buf[pt]))
+ is_series = 0;
+ else {
+ while(isdigit(subject->buf[--pt]));
+ }
+
+ if(is_series && subject->buf[pt--] != '/')
+ is_series = 0;
+
+ if (!isdigit(subject->buf[pt]))
+ is_series = 0;
+ if (is_series)
+ while(isdigit(subject->buf[--pt]));
+
+ pt++;
+
+ ret = sscanf(subject->buf + pt, "%d/%d]", &num, &total);
+ if (ret == 2){
+ mi->series_id = num;
+ mi->series_len = total;
+ }
+ }
+
if (!mi->keep_non_patch_brackets_in_subject ||
(7 <= remove &&
memmem(subject->buf + at, remove, "PATCH", 5)))
@@ -1154,6 +1187,8 @@ void setup_mailinfo(struct mailinfo *mi)
mi->header_stage = 1;
mi->use_inbody_headers = 1;
mi->content_top = mi->content;
+ mi->series_id = -1;
+ mi->series_len = -1;
git_config(git_mailinfo_config, mi);
}
diff --git a/mailinfo.h b/mailinfo.h
index 04a25351d..bd4f7c9e0 100644
--- a/mailinfo.h
+++ b/mailinfo.h
@@ -21,6 +21,8 @@ struct mailinfo {
struct strbuf **content_top;
struct strbuf charset;
char *message_id;
+ int series_id; /* Id of the patch within a patch series. -1 if not a patch series */
+ int series_len; /* Length of the patch series. -1 if not a patch series */
enum {
TE_DONTCARE, TE_QP, TE_BASE64
} transfer_encoding;
--
2.15.0.169.g3d3eebb67.dirty
next prev parent reply other threads:[~2017-11-13 17:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 10:24 [RFC] cover-at-tip Nicolas Morey-Chaisemartin
2017-11-10 15:37 ` Nicolas Morey-Chaisemartin
2017-11-10 18:22 ` Junio C Hamano
2017-11-13 7:58 ` Nicolas Morey-Chaisemartin
2017-11-13 9:48 ` Junio C Hamano
2017-11-13 10:30 ` Junio C Hamano
2017-11-13 10:48 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 0/3] Add support for --cover-at-tip Nicolas Morey-Chaisemartin
2017-11-13 19:40 ` Jonathan Tan
2017-11-13 19:53 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` Nicolas Morey-Chaisemartin [this message]
2017-11-14 5:47 ` [RFC 1/3] mailinfo: extract patch series id Junio C Hamano
2017-11-14 9:10 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 2/3] am: semi working --cover-at-tip Nicolas Morey-Chaisemartin
2017-11-14 6:00 ` Junio C Hamano
2017-11-14 9:17 ` Nicolas Morey-Chaisemartin
2017-11-16 16:21 ` Nicolas Morey-Chaisemartin
2017-11-17 1:54 ` Junio C Hamano
2017-11-13 17:13 ` [RFC 3/3] log: add an option to generate cover letter from a branch tip Nicolas Morey-Chaisemartin
2017-11-14 6:14 ` Junio C Hamano
2017-11-14 9:28 ` Nicolas Morey-Chaisemartin
2017-11-14 13:05 ` Junio C Hamano
2017-11-14 13:40 ` Nicolas Morey-Chaisemartin
2017-11-14 14:52 ` Junio C Hamano
2017-11-10 18:28 ` [RFC] cover-at-tip Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2252b046-a608-b2aa-d67a-8f7e95fe2dbc@suse.de \
--to=nmoreychaisemartin@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).