From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.de>
Cc: git@vger.kernel.org
Subject: Re: [RFC 2/3] am: semi working --cover-at-tip
Date: Tue, 14 Nov 2017 15:00:20 +0900 [thread overview]
Message-ID: <xmqqbmk54cy3.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <948b19c2-9f2d-de9d-1e0a-6681dc9317a9@suse.de> (Nicolas Morey-Chaisemartin's message of "Mon, 13 Nov 2017 18:13:36 +0100")
Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.de> writes:
> if (!git_config_get_bool("commit.gpgsign", &gpgsign))
> state->sign_commit = gpgsign ? "" : NULL;
> +
> }
Please give at least a cursory proof-reading before sending things
out.
> @@ -1106,14 +1131,6 @@ static void am_next(struct am_state *state)
>
> oidclr(&state->orig_commit);
> unlink(am_path(state, "original-commit"));
> -
> - if (!get_oid("HEAD", &head))
> - write_state_text(state, "abort-safety", oid_to_hex(&head));
> - else
> - write_state_text(state, "abort-safety", "");
> -
> - state->cur++;
> - write_state_count(state, "next", state->cur);
Moving these lines to a later part of the source file is fine, but
can you do so as a separate preparatory patch that does not change
anything else? That would unclutter the main patch that adds the
feature, allowing better reviews from reviewers.
The hunk below...
> +/**
> + * Increments the patch pointer, and cleans am_state for the application of the
> + * next patch.
> + */
> +static void am_next(struct am_state *state)
> +{
> + struct object_id head;
> +
> + /* Flush the cover letter if needed */
> + if (state->cover_at_tip == 1 &&
> + state->series_len > 0 &&
> + state->series_id == state->series_len &&
> + state->cover_id > 0)
> + do_apply_cover(state);
> +
> + am_clean(state);
> +
> + if (!get_oid("HEAD", &head))
> + write_state_text(state, "abort-safety", oid_to_hex(&head));
> + else
> + write_state_text(state, "abort-safety", "");
> +
> + state->cur++;
> + write_state_count(state, "next", state->cur);
> +}
... if you followed that "separate preparatory step" approach, would
show clearly that you added the logic to call do_apply_cover() when
we transition after applying the Nth patch of a series with N patches,
as all the existing lines will show only as unchanged context lines.
By the way, don't we want to sanity check state->last (which we
learn by running "git mailsplit" that splits the incoming mbox into
pieces and counts the number of messages) against state->series_len?
Sometimes people send [PATCH 0-6/6], a 6-patch series with a cover
letter, and then follow-up with [PATCH 7/6]. For somebody like me,
it would be more convenient if the above code (more-or-less) ignored
series_len and called do_apply_cover() after applying the last patch
(which would be [PATCH 7/6]) based on what state->last says.
Thanks.
next prev parent reply other threads:[~2017-11-14 6:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 10:24 [RFC] cover-at-tip Nicolas Morey-Chaisemartin
2017-11-10 15:37 ` Nicolas Morey-Chaisemartin
2017-11-10 18:22 ` Junio C Hamano
2017-11-13 7:58 ` Nicolas Morey-Chaisemartin
2017-11-13 9:48 ` Junio C Hamano
2017-11-13 10:30 ` Junio C Hamano
2017-11-13 10:48 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 0/3] Add support for --cover-at-tip Nicolas Morey-Chaisemartin
2017-11-13 19:40 ` Jonathan Tan
2017-11-13 19:53 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 1/3] mailinfo: extract patch series id Nicolas Morey-Chaisemartin
2017-11-14 5:47 ` Junio C Hamano
2017-11-14 9:10 ` Nicolas Morey-Chaisemartin
2017-11-13 17:13 ` [RFC 2/3] am: semi working --cover-at-tip Nicolas Morey-Chaisemartin
2017-11-14 6:00 ` Junio C Hamano [this message]
2017-11-14 9:17 ` Nicolas Morey-Chaisemartin
2017-11-16 16:21 ` Nicolas Morey-Chaisemartin
2017-11-17 1:54 ` Junio C Hamano
2017-11-13 17:13 ` [RFC 3/3] log: add an option to generate cover letter from a branch tip Nicolas Morey-Chaisemartin
2017-11-14 6:14 ` Junio C Hamano
2017-11-14 9:28 ` Nicolas Morey-Chaisemartin
2017-11-14 13:05 ` Junio C Hamano
2017-11-14 13:40 ` Nicolas Morey-Chaisemartin
2017-11-14 14:52 ` Junio C Hamano
2017-11-10 18:28 ` [RFC] cover-at-tip Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmk54cy3.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=NMoreyChaisemartin@suse.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).