git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, sunshine@sunshineco.com,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ci/install-depends: attempt to fix "brew cask" stuff
Date: Sat, 23 Jan 2021 22:18:13 -0800	[thread overview]
Message-ID: <xmqqeeia26ze.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <830a88ce-1728-a6a5-f60d-59328f85932c@gmail.com> (Philippe Blain's message of "Sat, 23 Jan 2021 21:41:29 -0500")

Philippe Blain <levraiphilippeblain@gmail.com> writes:

> Yes, a quick Google search pointed me to a blog post [1]
> that mentions using 'fail-fast: false' in the test matrix so that
> one failing job does not automatically cancel the rest of the jobs
> in the matrix (the default is 'true') [2].
>
> If we apply that to all four matrices in the workflow file,
> (windows-test, vs-test, regular and dockerized), it would be
> something like this:

I am assuming that "failure of build stops tests from running",
which is done on the windows/vs-build side, is still kept with
this change.  If that is the case, it sounds quite sensible.

> I've CC-ed Dscho regarding if we also want this for the Windows tests,
> (I don't see why not) and if we feel it's a good idea I can
> send a proper patch.

I often see windows/vs-test #4 fail first and take other 9 with it.
We may see some interesting patterns to emerge, when we run all of
them (and let all of them fail X-<).

Thanks for working on this.

  reply	other threads:[~2021-01-24  6:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  3:14 [PATCH] ci/install-depends: attempt to fix "brew cask" stuff Junio C Hamano
2021-01-15  5:48 ` Junio C Hamano
2021-01-15  6:05   ` Eric Sunshine
2021-01-15 14:27   ` Derrick Stolee
2021-01-15 19:52     ` Junio C Hamano
2021-01-15 19:59 ` Jeff King
2021-01-15 20:07   ` Eric Sunshine
2021-01-15 20:46     ` Jeff King
2021-02-01 22:11       ` SZEDER Gábor
2021-01-24  2:41   ` Philippe Blain
2021-01-24  6:18     ` Junio C Hamano [this message]
2021-01-25  0:56     ` Taylor Blau
2021-01-27 22:21     ` Jeff King
2021-01-28  5:23       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeeia26ze.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=levraiphilippeblain@gmail.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).