From: Jeff King <peff@peff.net>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, sunshine@sunshineco.com,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ci/install-depends: attempt to fix "brew cask" stuff
Date: Wed, 27 Jan 2021 17:21:11 -0500 [thread overview]
Message-ID: <YBHnV80bBQOxZH1O@coredump.intra.peff.net> (raw)
In-Reply-To: <830a88ce-1728-a6a5-f60d-59328f85932c@gmail.com>
On Sat, Jan 23, 2021 at 09:41:29PM -0500, Philippe Blain wrote:
> > So we could split the macos test out. It would probably involve
> > duplicating a little bit of the content, but we do something similar for
> > the dockerized builds. It might be that there is an option we can set to
> > say "keep building the others even if one of these fails", which would
> > give us the best of both.
>
> Yes, a quick Google search pointed me to a blog post [1]
> that mentions using 'fail-fast: false' in the test matrix so that
> one failing job does not automatically cancel the rest of the jobs
> in the matrix (the default is 'true') [2].
>
> If we apply that to all four matrices in the workflow file,
> (windows-test, vs-test, regular and dockerized), it would be
> something like this:
Thanks, that's exactly what I think we'd want.
The downside, of course, is that a failure that will happen on every
platform will mean wasted CPU to trigger the same failure over and over.
But:
- I rarely see that myself, because I wouldn't bother pushing up to CI
until "make test" passed locally. So usually I'm finding portability
issues via CI. Other people might be different, though.
- we already have the Windows tests in a separate matrix anyway, so a
failure on Linux would run the whole Windows suite (which is an
order of magnitude more expensive)
- even within the Windows matrix, I think running the rest of the
tests after a failure is still valuable. If there's a second
failure, you save a round-trip to CI (so it doesn't reduce CPU, but
it may help latency to reach a passing state).
-Peff
next prev parent reply other threads:[~2021-01-27 23:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 3:14 [PATCH] ci/install-depends: attempt to fix "brew cask" stuff Junio C Hamano
2021-01-15 5:48 ` Junio C Hamano
2021-01-15 6:05 ` Eric Sunshine
2021-01-15 14:27 ` Derrick Stolee
2021-01-15 19:52 ` Junio C Hamano
2021-01-15 19:59 ` Jeff King
2021-01-15 20:07 ` Eric Sunshine
2021-01-15 20:46 ` Jeff King
2021-02-01 22:11 ` SZEDER Gábor
2021-01-24 2:41 ` Philippe Blain
2021-01-24 6:18 ` Junio C Hamano
2021-01-25 0:56 ` Taylor Blau
2021-01-27 22:21 ` Jeff King [this message]
2021-01-28 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBHnV80bBQOxZH1O@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=levraiphilippeblain@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).