From: Philippe Blain <levraiphilippeblain@gmail.com>
To: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ci/install-depends: attempt to fix "brew cask" stuff
Date: Sat, 23 Jan 2021 21:41:29 -0500 [thread overview]
Message-ID: <830a88ce-1728-a6a5-f60d-59328f85932c@gmail.com> (raw)
In-Reply-To: <YAH0G+Y4fIxoTeZa@coredump.intra.peff.net>
Hi everyone,
Le 2021-01-15 à 14:59, Jeff King a écrit :
> On Thu, Jan 14, 2021 at 07:14:34PM -0800, Junio C Hamano wrote:
>
>> It seems that homebrew suddenly started giving us trouble, like this:
>>
>> https://github.com/git/git/runs/1705953982?check_suite_focus=true#step:3:70
>>
>> Here is my attempt to work it around by blindly following the
>> suggested course of action in the error message, without knowing
>> what I am doing X-<. I am not a Mac person.
>>
>> What is frustrating is that every time we hit a minor snag like this
>> to break one of the jobs, all other unrelated jobs are also taken
>> down.
>
> I think that has to do with the grouping in the workflow file (the
> Windows builds, for example, will cancel the _other_ Windows tests if
> they fail, but not the Linux ones).
>
> So we could split the macos test out. It would probably involve
> duplicating a little bit of the content, but we do something similar for
> the dockerized builds. It might be that there is an option we can set to
> say "keep building the others even if one of these fails", which would
> give us the best of both.
Yes, a quick Google search pointed me to a blog post [1]
that mentions using 'fail-fast: false' in the test matrix so that
one failing job does not automatically cancel the rest of the jobs
in the matrix (the default is 'true') [2].
If we apply that to all four matrices in the workflow file,
(windows-test, vs-test, regular and dockerized), it would be
something like this:
~~~
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index aef6643648..6c31f978bc 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -125,6 +125,7 @@ jobs:
strategy:
matrix:
nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
+ fail-fast: false
steps:
- uses: actions/checkout@v1
- name: download build artifacts
@@ -229,6 +230,7 @@ jobs:
strategy:
matrix:
nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
+ fail-fast: false
steps:
- uses: actions/checkout@v1
- name: download git-sdk-64-minimal
@@ -289,6 +291,7 @@ jobs:
- jobname: GETTEXT_POISON
cc: gcc
pool: ubuntu-latest
+ fail-fast: false
env:
CC: ${{matrix.vector.cc}}
jobname: ${{matrix.vector.jobname}}
@@ -315,6 +318,7 @@ jobs:
image: alpine
- jobname: Linux32
image: daald/ubuntu32:xenial
+ fail-fast: false
env:
jobname: ${{matrix.vector.jobname}}
runs-on: ubuntu-latest
~~~
I've CC-ed Dscho regarding if we also want this for the Windows tests,
(I don't see why not) and if we feel it's a good idea I can
send a proper patch.
Cheers,
Philippe.
[1] https://www.edwardthomson.com/blog/github_actions_6_fail_fast_matrix_workflows.html
[2] https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
next prev parent reply other threads:[~2021-01-24 2:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 3:14 [PATCH] ci/install-depends: attempt to fix "brew cask" stuff Junio C Hamano
2021-01-15 5:48 ` Junio C Hamano
2021-01-15 6:05 ` Eric Sunshine
2021-01-15 14:27 ` Derrick Stolee
2021-01-15 19:52 ` Junio C Hamano
2021-01-15 19:59 ` Jeff King
2021-01-15 20:07 ` Eric Sunshine
2021-01-15 20:46 ` Jeff King
2021-02-01 22:11 ` SZEDER Gábor
2021-01-24 2:41 ` Philippe Blain [this message]
2021-01-24 6:18 ` Junio C Hamano
2021-01-25 0:56 ` Taylor Blau
2021-01-27 22:21 ` Jeff King
2021-01-28 5:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=830a88ce-1728-a6a5-f60d-59328f85932c@gmail.com \
--to=levraiphilippeblain@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).