From: Junio C Hamano <gitster@pobox.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] rebase: pass --[no-]signoff option to git am
Date: Sun, 16 Apr 2017 21:17:19 -0700 [thread overview]
Message-ID: <xmqqa87fk6r4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAOxFTczZS6aDGzDVLskQGObtDOeLL_i3-8jJdh8OrQFXVGbOHQ@mail.gmail.com> (Giuseppe Bilotta's message of "Sat, 15 Apr 2017 19:45:54 +0200")
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> Damnit! I just realized that I forgot to amend before the format-patch:
>
> On Sat, Apr 15, 2017 at 4:41 PM, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
>
>> +signoff! passed to 'git am'
>
> This should be without the ! or --no-signoff is not accepted. Do I
> need to resend or ... ?
Resend or send something that can be "git apply"ed, which would
reduce the chance of mistakes. Let the maintainer _TYPE_ as little
as possible, or typoes will sneak in.
Thanks.
next prev parent reply other threads:[~2017-04-17 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 14:41 [PATCH 0/3] rebase --signoff Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 1/3] builtin/am: obey --signoff also when --rebasing Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 2/3] builtin/am: fold am_signoff() into am_append_signoff() Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 3/3] rebase: pass --[no-]signoff option to git am Giuseppe Bilotta
2017-04-15 17:45 ` Giuseppe Bilotta
2017-04-17 4:17 ` Junio C Hamano [this message]
2017-04-17 7:12 ` [PATCH 0/3] rebase --signoff Junio C Hamano
2017-04-17 14:12 ` Giuseppe Bilotta
2017-04-18 0:14 ` Junio C Hamano
2017-04-18 8:40 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa87fk6r4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).