From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] rebase --signoff
Date: Mon, 17 Apr 2017 16:12:19 +0200 [thread overview]
Message-ID: <CAOxFTczhfvzhrSiCj7SgLXbO3hrBW_QaDVZMpOqrij_hCJyCzg@mail.gmail.com> (raw)
In-Reply-To: <xmqqshl7ik21.fsf@gitster.mtv.corp.google.com>
On Mon, Apr 17, 2017 at 9:12 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Two questions.
>
> - Is it better to add a brand new test script than adding new tests
> to existing scripts that test "git rebase"?
Since this is a completely (in some sense) new feature, I felt it was
appropriate to put all --signoff-related tests in their own file. So,
if the need arises to put more tests concerning the interaction of
signoff with other stuff, this new test file can be extended.
> - How does this interact with "git rebase -i" and other modes of
> operation?
A better question would maybe be how do we want this to interact? For
example, with -i: do we want -i --signoff to just sign off everything?
Or do we want a new -i command (o, signoff) to signoff only individual
commits on request? When preserving merges, do we want to sign-off
merge-commits too? I'm not entirely sure what the best policy would
be.
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2017-04-17 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 14:41 [PATCH 0/3] rebase --signoff Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 1/3] builtin/am: obey --signoff also when --rebasing Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 2/3] builtin/am: fold am_signoff() into am_append_signoff() Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 3/3] rebase: pass --[no-]signoff option to git am Giuseppe Bilotta
2017-04-15 17:45 ` Giuseppe Bilotta
2017-04-17 4:17 ` Junio C Hamano
2017-04-17 7:12 ` [PATCH 0/3] rebase --signoff Junio C Hamano
2017-04-17 14:12 ` Giuseppe Bilotta [this message]
2017-04-18 0:14 ` Junio C Hamano
2017-04-18 8:40 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOxFTczhfvzhrSiCj7SgLXbO3hrBW_QaDVZMpOqrij_hCJyCzg@mail.gmail.com \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).