From: Junio C Hamano <gitster@pobox.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] rebase --signoff
Date: Mon, 17 Apr 2017 00:12:54 -0700 [thread overview]
Message-ID: <xmqqshl7ik21.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170415144103.11986-1-giuseppe.bilotta@gmail.com> (Giuseppe Bilotta's message of "Sat, 15 Apr 2017 16:41:00 +0200")
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> Allow signing off a whole patchset by rebasing it with the --signoff
> option, which is simply passed through to git am.
> Documentation/git-rebase.txt | 5 +++++
> builtin/am.c | 39 +++++++++++++++++--------------------
> git-rebase.sh | 3 ++-
> t/t3428-rebase-signoff.sh | 46 ++++++++++++++++++++++++++++++++++++++++++++
Two questions.
- Is it better to add a brand new test script than adding new tests
to existing scripts that test "git rebase"?
- How does this interact with "git rebase -i" and other modes of
operation?
next prev parent reply other threads:[~2017-04-17 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 14:41 [PATCH 0/3] rebase --signoff Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 1/3] builtin/am: obey --signoff also when --rebasing Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 2/3] builtin/am: fold am_signoff() into am_append_signoff() Giuseppe Bilotta
2017-04-15 14:41 ` [PATCH 3/3] rebase: pass --[no-]signoff option to git am Giuseppe Bilotta
2017-04-15 17:45 ` Giuseppe Bilotta
2017-04-17 4:17 ` Junio C Hamano
2017-04-17 7:12 ` Junio C Hamano [this message]
2017-04-17 14:12 ` [PATCH 0/3] rebase --signoff Giuseppe Bilotta
2017-04-18 0:14 ` Junio C Hamano
2017-04-18 8:40 ` Giuseppe Bilotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshl7ik21.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).