* [PATCH 0/2] ci(main): upgrade actions/checkout to v3
@ 2022-10-10 7:48 Oscar Dominguez via GitGitGadget
2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Oscar Dominguez via GitGitGadget @ 2022-10-10 7:48 UTC (permalink / raw)
To: git; +Cc: Oscar Dominguez
Description
===========
Upgrades actions/checkout to v3 in .github/workflows/main.yml
Oscar Dominguez (2):
ci(main): upgrade actions/checkout to v3
ci(main): linux32 uses actions/checkout@v2
.github/workflows/main.yml | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v1
Pull-Request: https://github.com/git/git/pull/1354
--
gitgitgadget
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 1/2] ci(main): upgrade actions/checkout to v3 2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget @ 2022-10-10 7:48 ` Oscar Dominguez via GitGitGadget 2022-10-10 20:55 ` Junio C Hamano 2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget 2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget 2 siblings, 1 reply; 13+ messages in thread From: Oscar Dominguez via GitGitGadget @ 2022-10-10 7:48 UTC (permalink / raw) To: git; +Cc: Oscar Dominguez, Oscar Dominguez From: Oscar Dominguez <dominguez.celada@gmail.com> to be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches. Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com> --- .github/workflows/main.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 831f4df56c5..8dc9d938159 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -83,7 +83,7 @@ jobs: if: needs.ci-config.outputs.enabled == 'yes' runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: git-for-windows/setup-git-for-windows-sdk@v1 - name: build shell: bash @@ -138,10 +138,10 @@ jobs: GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'" runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: git-for-windows/setup-git-for-windows-sdk@v1 - name: initialize vcpkg - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: repository: 'microsoft/vcpkg' path: 'compat/vcbuild/vcpkg' @@ -258,7 +258,7 @@ jobs: runs_on_pool: ${{matrix.vector.pool}} runs-on: ${{matrix.vector.pool}} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: ci/install-dependencies.sh - run: ci/run-build-and-tests.sh - name: print test failures @@ -291,7 +291,7 @@ jobs: runs-on: ubuntu-latest container: ${{matrix.vector.image}} steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v3 - run: ci/install-docker-dependencies.sh - run: ci/run-build-and-tests.sh - name: print test failures @@ -311,7 +311,7 @@ jobs: jobname: StaticAnalysis runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: ci/install-dependencies.sh - run: ci/run-static-analysis.sh - run: ci/check-directional-formatting.bash @@ -331,7 +331,7 @@ jobs: artifact: sparse-20.04 - name: Install the current `sparse` package run: sudo dpkg -i sparse-20.04/sparse_*.deb - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Install other dependencies run: ci/install-dependencies.sh - run: make sparse @@ -343,6 +343,6 @@ jobs: jobname: Documentation runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: ci/install-dependencies.sh - run: ci/test-documentation.sh -- gitgitgadget ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] ci(main): upgrade actions/checkout to v3 2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget @ 2022-10-10 20:55 ` Junio C Hamano 0 siblings, 0 replies; 13+ messages in thread From: Junio C Hamano @ 2022-10-10 20:55 UTC (permalink / raw) To: Oscar Dominguez via GitGitGadget; +Cc: git, Oscar Dominguez "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Oscar Dominguez <dominguez.celada@gmail.com> > > to be up to date with actions/checkout opens the door to use the latest > features if necessary and get the latest security patches. > > Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com> > --- > .github/workflows/main.yml | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Hmph. When 0dc787a9 (ci: accelerate the checkout, 2021-07-04) updated us from actions/checkout@v1 to actions/checkout@v2 it listed a lot more concrete "what we gain by doing this change", than the hand-wavy "opens the door" argument. And it left container jobs at @v1 with an explanation that @v2 seemed to be incompatible. If the issue has that been resolved in @v3, it would be necessary to say that the issue has been resolved and it is safe to use @v3 there in the proposed log message. > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 831f4df56c5..8dc9d938159 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > ... > @@ -291,7 +291,7 @@ jobs: > runs-on: ubuntu-latest > container: ${{matrix.vector.image}} > steps: > - - uses: actions/checkout@v1 > + - uses: actions/checkout@v3 > - run: ci/install-docker-dependencies.sh > - run: ci/run-build-and-tests.sh > - name: print test failures ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget 2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget @ 2022-10-10 7:48 ` Oscar Dominguez via GitGitGadget 2022-10-10 21:00 ` Junio C Hamano 2022-10-10 21:43 ` Junio C Hamano 2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget 2 siblings, 2 replies; 13+ messages in thread From: Oscar Dominguez via GitGitGadget @ 2022-10-10 7:48 UTC (permalink / raw) To: git; +Cc: Oscar Dominguez, Oscar Dominguez From: Oscar Dominguez <dominguez.celada@gmail.com> to prevent issue tracked in https://github.com/actions/checkout/issues/560 Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com> --- .github/workflows/main.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8dc9d938159..4eb5042f0d6 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -281,17 +281,20 @@ jobs: vector: - jobname: linux-musl image: alpine + checkout_version: 3 - jobname: linux32 os: ubuntu32 image: daald/ubuntu32:xenial + checkout_version: 2 - jobname: pedantic image: fedora + checkout_version: 3 env: jobname: ${{matrix.vector.jobname}} runs-on: ubuntu-latest container: ${{matrix.vector.image}} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@${{matrix.vector.checkout_version}} - run: ci/install-docker-dependencies.sh - run: ci/run-build-and-tests.sh - name: print test failures -- gitgitgadget ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget @ 2022-10-10 21:00 ` Junio C Hamano 2022-10-10 21:43 ` Junio C Hamano 1 sibling, 0 replies; 13+ messages in thread From: Junio C Hamano @ 2022-10-10 21:00 UTC (permalink / raw) To: Oscar Dominguez via GitGitGadget; +Cc: git, Oscar Dominguez "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Oscar Dominguez <dominguez.celada@gmail.com> > > to prevent issue tracked in https://github.com/actions/checkout/issues/560 > > Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com> > --- > .github/workflows/main.yml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) So, this is "[Patch 1/2] broke the musl job by blindly updating them to v3 and here is a fix-up" patch? Can we rearrange so that we have no such "oops here is a fix" that breaks bisection easily? > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 8dc9d938159..4eb5042f0d6 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -281,17 +281,20 @@ jobs: > vector: > - jobname: linux-musl > image: alpine > + checkout_version: 3 > - jobname: linux32 > os: ubuntu32 > image: daald/ubuntu32:xenial > + checkout_version: 2 > - jobname: pedantic > image: fedora > + checkout_version: 3 > env: > jobname: ${{matrix.vector.jobname}} > runs-on: ubuntu-latest > container: ${{matrix.vector.image}} > steps: > - - uses: actions/checkout@v3 > + - uses: actions/checkout@${{matrix.vector.checkout_version}} > - run: ci/install-docker-dependencies.sh > - run: ci/run-build-and-tests.sh > - name: print test failures ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget 2022-10-10 21:00 ` Junio C Hamano @ 2022-10-10 21:43 ` Junio C Hamano 1 sibling, 0 replies; 13+ messages in thread From: Junio C Hamano @ 2022-10-10 21:43 UTC (permalink / raw) To: Oscar Dominguez via GitGitGadget; +Cc: git, Oscar Dominguez "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Oscar Dominguez <dominguez.celada@gmail.com> > > to prevent issue tracked in https://github.com/actions/checkout/issues/560 > > Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com> > --- > .github/workflows/main.yml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 8dc9d938159..4eb5042f0d6 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -281,17 +281,20 @@ jobs: > ... > steps: > - - uses: actions/checkout@v3 > + - uses: actions/checkout@${{matrix.vector.checkout_version}} > - run: ci/install-docker-dependencies.sh > - run: ci/run-build-and-tests.sh > - name: print test failures I think the breakage we see in https://github.com/git/git/actions/runs/3222517697 is due to this change. ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2] ci(main): upgrade actions/checkout to v3 2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget 2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget 2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget @ 2022-12-05 10:01 ` Oscar Dominguez via GitGitGadget 2022-12-05 23:28 ` Junio C Hamano 2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano 2 siblings, 2 replies; 13+ messages in thread From: Oscar Dominguez via GitGitGadget @ 2022-12-05 10:01 UTC (permalink / raw) To: git; +Cc: Oscar Dominguez, Oscar Dominguez From: Oscar Dominguez <dominguez.celada@gmail.com> To be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches. This also avoids a couple of deprecation warnings in the CI runs. Note: The `actions/checkout` Action has been known to be broken in i686 containers as of v2, therefore we keep forcing it to v1 there. See actions/runner#2115 for more details. Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- ci(main): upgrade actions/checkout to v3 Description =========== Upgrades actions/checkout to v3 in .github/workflows/main.yml Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v2 Pull-Request: https://github.com/git/git/pull/1354 Range-diff vs v1: 1: 2dbb779f7fd ! 1: 26fad15f97a ci(main): upgrade actions/checkout to v3 @@ Metadata ## Commit message ## ci(main): upgrade actions/checkout to v3 - to be up to date with actions/checkout opens the door to use the latest + To be up to date with actions/checkout opens the door to use the latest features if necessary and get the latest security patches. - Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com> + This also avoids a couple of deprecation warnings in the CI runs. + + Note: The `actions/checkout` Action has been known to be broken in i686 + containers as of v2, therefore we keep forcing it to v1 there. See + actions/runner#2115 for more details. + + Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com> + Signed-off-by: Junio C Hamano <gitster@pobox.com> + Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> ## .github/workflows/main.yml ## @@ .github/workflows/main.yml: jobs: @@ .github/workflows/main.yml: jobs: runs-on: ubuntu-latest container: ${{matrix.vector.image}} steps: -- - uses: actions/checkout@v1 + - uses: actions/checkout@v3 ++ if: matrix.vector.jobname != 'linux32' + - uses: actions/checkout@v1 ++ if: matrix.vector.jobname == 'linux32' - run: ci/install-docker-dependencies.sh - run: ci/run-build-and-tests.sh - name: print test failures 2: 4ee163b9a2c < -: ----------- ci(main): linux32 uses actions/checkout@v2 .github/workflows/main.yml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 831f4df56c5..5262823eb1c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -83,7 +83,7 @@ jobs: if: needs.ci-config.outputs.enabled == 'yes' runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: git-for-windows/setup-git-for-windows-sdk@v1 - name: build shell: bash @@ -138,10 +138,10 @@ jobs: GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'" runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: git-for-windows/setup-git-for-windows-sdk@v1 - name: initialize vcpkg - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: repository: 'microsoft/vcpkg' path: 'compat/vcbuild/vcpkg' @@ -258,7 +258,7 @@ jobs: runs_on_pool: ${{matrix.vector.pool}} runs-on: ${{matrix.vector.pool}} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: ci/install-dependencies.sh - run: ci/run-build-and-tests.sh - name: print test failures @@ -291,7 +291,10 @@ jobs: runs-on: ubuntu-latest container: ${{matrix.vector.image}} steps: + - uses: actions/checkout@v3 + if: matrix.vector.jobname != 'linux32' - uses: actions/checkout@v1 + if: matrix.vector.jobname == 'linux32' - run: ci/install-docker-dependencies.sh - run: ci/run-build-and-tests.sh - name: print test failures @@ -311,7 +314,7 @@ jobs: jobname: StaticAnalysis runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: ci/install-dependencies.sh - run: ci/run-static-analysis.sh - run: ci/check-directional-formatting.bash @@ -331,7 +334,7 @@ jobs: artifact: sparse-20.04 - name: Install the current `sparse` package run: sudo dpkg -i sparse-20.04/sparse_*.deb - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Install other dependencies run: ci/install-dependencies.sh - run: make sparse @@ -343,6 +346,6 @@ jobs: jobname: Documentation runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: ci/install-dependencies.sh - run: ci/test-documentation.sh base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb -- gitgitgadget ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2] ci(main): upgrade actions/checkout to v3 2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget @ 2022-12-05 23:28 ` Junio C Hamano 2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano 1 sibling, 0 replies; 13+ messages in thread From: Junio C Hamano @ 2022-12-05 23:28 UTC (permalink / raw) To: Oscar Dominguez via GitGitGadget; +Cc: git, Oscar Dominguez "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Oscar Dominguez <dominguez.celada@gmail.com> > > To be up to date with actions/checkout opens the door to use the latest > features if necessary and get the latest security patches. > > This also avoids a couple of deprecation warnings in the CI runs. > > Note: The `actions/checkout` Action has been known to be broken in i686 > containers as of v2, therefore we keep forcing it to v1 there. See > actions/runner#2115 for more details. > > Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com> > Signed-off-by: Junio C Hamano <gitster@pobox.com> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- I do not know about Johannes, but the latter two S-o-b by others are very questionable, as this is the first time I see this iteration of the patch. The chain of S-o-b is used to record that the author handed the patch to somebody else who forwarded it to another (i.e. the order of custody), and the above makes it look as if I picked this iteration of your patch up, passed it to Johannes, and he gave it to the mailing list readers with this message. If you wanted to say "Input from Johannes helped me greatly while I polished the earlier work to produce this version", it is more appropriate to end the proposed log message with: Helped-by: Johannes Schindelin <...> Signed-off-by: Oscar Dominguez <...> in chronological order. In any case, I've been disturbed by the "Node 12 is going away, use the one that works with Node 16" warning at GitHub CI for the past few weeks and it is very welcome to see this topic moving forward. Thanks for working on it. ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] ci: use actions/{upload,download}-artifact@v3 2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget 2022-12-05 23:28 ` Junio C Hamano @ 2022-12-06 8:24 ` Junio C Hamano 2022-12-06 21:21 ` Johannes Schindelin 1 sibling, 1 reply; 13+ messages in thread From: Junio C Hamano @ 2022-12-06 8:24 UTC (permalink / raw) To: git; +Cc: Oscar Dominguez GitHub CI jobs stopped complaining about use of deprecated actions that requires deprecated Node.js 12 for some steps, thanks to a recent work by Oscar Dominguez to upgrade actions/checkout from v2 (which required Node.js 12) to v3 (which runs with recommended Node.js 16). Upgrade actions/upload-artifact and actions/download-artifact from v2 to v3, following suit. Signed-off-by: Junio C Hamano <gitster@pobox.com> --- * The CI run hasn't finished, but it seems to be doing well https://github.com/git/git/actions/runs/3627513480 We are also getting complaint about our use of set-output command that is deprecated, which will need to be addressed, too. .github/workflows/main.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5262823eb1..7a24c6613e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -94,7 +94,7 @@ jobs: - name: zip up tracked files run: git archive -o artifacts/tracked.tar.gz HEAD - name: upload tracked files and build artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: windows-artifacts path: artifacts @@ -108,7 +108,7 @@ jobs: nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] steps: - name: download tracked files and build artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: windows-artifacts path: ${{github.workspace}} @@ -125,7 +125,7 @@ jobs: run: ci/print-test-failures.sh - name: Upload failed tests' directories if: failure() && env.FAILED_TEST_ARTIFACTS != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: failed-tests-windows path: ${{env.FAILED_TEST_ARTIFACTS}} @@ -177,7 +177,7 @@ jobs: - name: zip up tracked files run: git archive -o artifacts/tracked.tar.gz HEAD - name: upload tracked files and build artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: vs-artifacts path: artifacts @@ -192,7 +192,7 @@ jobs: steps: - uses: git-for-windows/setup-git-for-windows-sdk@v1 - name: download tracked files and build artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: vs-artifacts path: ${{github.workspace}} @@ -210,7 +210,7 @@ jobs: run: ci/print-test-failures.sh - name: Upload failed tests' directories if: failure() && env.FAILED_TEST_ARTIFACTS != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: failed-tests-windows path: ${{env.FAILED_TEST_ARTIFACTS}} @@ -267,7 +267,7 @@ jobs: run: ci/print-test-failures.sh - name: Upload failed tests' directories if: failure() && env.FAILED_TEST_ARTIFACTS != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: failed-tests-${{matrix.vector.jobname}} path: ${{env.FAILED_TEST_ARTIFACTS}} -- 2.39.0-rc2 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] ci: use actions/{upload,download}-artifact@v3 2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano @ 2022-12-06 21:21 ` Johannes Schindelin 2022-12-06 23:41 ` Junio C Hamano 0 siblings, 1 reply; 13+ messages in thread From: Johannes Schindelin @ 2022-12-06 21:21 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Oscar Dominguez Hi Junio, On Tue, 6 Dec 2022, Junio C Hamano wrote: > GitHub CI jobs stopped complaining about use of deprecated actions > that requires deprecated Node.js 12 for some steps, thanks to a > recent work by Oscar Dominguez to upgrade actions/checkout from v2 > (which required Node.js 12) to v3 (which runs with recommended > Node.js 16). > > Upgrade actions/upload-artifact and actions/download-artifact from > v2 to v3, following suit. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > --- > * The CI run hasn't finished, but it seems to be doing well > https://github.com/git/git/actions/runs/3627513480 > > We are also getting complaint about our use of set-output command > that is deprecated, which will need to be addressed, too. See below. > .github/workflows/main.yml | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index 5262823eb1..7a24c6613e 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -94,7 +94,7 @@ jobs: > - name: zip up tracked files > run: git archive -o artifacts/tracked.tar.gz HEAD > - name: upload tracked files and build artifacts > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: windows-artifacts > path: artifacts > @@ -108,7 +108,7 @@ jobs: > nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] > steps: > - name: download tracked files and build artifacts > - uses: actions/download-artifact@v2 > + uses: actions/download-artifact@v3 > with: > name: windows-artifacts > path: ${{github.workspace}} > @@ -125,7 +125,7 @@ jobs: > run: ci/print-test-failures.sh > - name: Upload failed tests' directories > if: failure() && env.FAILED_TEST_ARTIFACTS != '' > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: failed-tests-windows > path: ${{env.FAILED_TEST_ARTIFACTS}} > @@ -177,7 +177,7 @@ jobs: > - name: zip up tracked files > run: git archive -o artifacts/tracked.tar.gz HEAD > - name: upload tracked files and build artifacts > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: vs-artifacts > path: artifacts > @@ -192,7 +192,7 @@ jobs: > steps: > - uses: git-for-windows/setup-git-for-windows-sdk@v1 > - name: download tracked files and build artifacts > - uses: actions/download-artifact@v2 > + uses: actions/download-artifact@v3 > with: > name: vs-artifacts > path: ${{github.workspace}} > @@ -210,7 +210,7 @@ jobs: > run: ci/print-test-failures.sh > - name: Upload failed tests' directories > if: failure() && env.FAILED_TEST_ARTIFACTS != '' > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 This is probably incorrect, but you wouldn't know until something failed in the `linux32` job. I already have a correct fix in https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c and was only waiting for the patch at the root of this here mail thread to advance further so I could contribute that fix, along with other replacements for deprecated operations. Maybe we can move these changes forward in a more orderly manner, with Oscar's patch advancing to `next` once it is done, and the other patches following after that? Ciao, Johannes > with: > name: failed-tests-windows > path: ${{env.FAILED_TEST_ARTIFACTS}} > @@ -267,7 +267,7 @@ jobs: > run: ci/print-test-failures.sh > - name: Upload failed tests' directories > if: failure() && env.FAILED_TEST_ARTIFACTS != '' > - uses: actions/upload-artifact@v2 > + uses: actions/upload-artifact@v3 > with: > name: failed-tests-${{matrix.vector.jobname}} > path: ${{env.FAILED_TEST_ARTIFACTS}} > -- > 2.39.0-rc2 > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ci: use actions/{upload,download}-artifact@v3 2022-12-06 21:21 ` Johannes Schindelin @ 2022-12-06 23:41 ` Junio C Hamano 2022-12-07 0:35 ` Junio C Hamano 0 siblings, 1 reply; 13+ messages in thread From: Junio C Hamano @ 2022-12-06 23:41 UTC (permalink / raw) To: Johannes Schindelin; +Cc: git, Oscar Dominguez Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> @@ -210,7 +210,7 @@ jobs: >> run: ci/print-test-failures.sh >> - name: Upload failed tests' directories >> if: failure() && env.FAILED_TEST_ARTIFACTS != '' >> - uses: actions/upload-artifact@v2 >> + uses: actions/upload-artifact@v3 > > This is probably incorrect, but you wouldn't know until something failed > in the `linux32` job. Yeah, that was what I was afraid to see. > I already have a correct fix in > https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c > and was only waiting for the patch at the root of this here mail thread to > advance further so I could contribute that fix, along with other > replacements for deprecated operations. Wonderful. > Maybe we can move these changes forward in a more orderly manner, with > Oscar's patch advancing to `next` once it is done, and the other patches > following after that? That was what I was planning to do anyway. Thanks. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ci: use actions/{upload,download}-artifact@v3 2022-12-06 23:41 ` Junio C Hamano @ 2022-12-07 0:35 ` Junio C Hamano 2022-12-07 12:33 ` Johannes Schindelin 0 siblings, 1 reply; 13+ messages in thread From: Junio C Hamano @ 2022-12-07 0:35 UTC (permalink / raw) To: Johannes Schindelin; +Cc: git, Oscar Dominguez Junio C Hamano <gitster@pobox.com> writes: >> This is probably incorrect, but you wouldn't know until something failed >> in the `linux32` job. > > Yeah, that was what I was afraid to see. > >> I already have a correct fix in >> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c >> and was only waiting for the patch at the root of this here mail thread to >> advance further so I could contribute that fix, along with other >> replacements for deprecated operations. > > Wonderful. > >> Maybe we can move these changes forward in a more orderly manner, with >> Oscar's patch advancing to `next` once it is done, and the other patches >> following after that? > > That was what I was planning to do anyway. Thanks. Eh, I should have made my intention clear. I'll drop this one (as I posted it primarily to fish out those who are interested in and more capable than I am at clearing the deprecation warnings from the CI), will mark Oscar's for 'next' (if I haven't done so already), wait for your updates and queue them on a topic forked from Oscar's (or on the same Oscar's topic), and cook them for the first or the second batch of the next cycle. Thanks. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ci: use actions/{upload,download}-artifact@v3 2022-12-07 0:35 ` Junio C Hamano @ 2022-12-07 12:33 ` Johannes Schindelin 0 siblings, 0 replies; 13+ messages in thread From: Johannes Schindelin @ 2022-12-07 12:33 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Oscar Dominguez Hi Junio, On Wed, 7 Dec 2022, Junio C Hamano wrote: > Junio C Hamano <gitster@pobox.com> writes: > > >> This is probably incorrect, but you wouldn't know until something failed > >> in the `linux32` job. > > > > Yeah, that was what I was afraid to see. > > > >> I already have a correct fix in > >> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c > >> and was only waiting for the patch at the root of this here mail thread to > >> advance further so I could contribute that fix, along with other > >> replacements for deprecated operations. > > > > Wonderful. > > > >> Maybe we can move these changes forward in a more orderly manner, with > >> Oscar's patch advancing to `next` once it is done, and the other patches > >> following after that? > > > > That was what I was planning to do anyway. Thanks. > > Eh, I should have made my intention clear. I'll drop this one (as I > posted it primarily to fish out those who are interested in and more > capable than I am at clearing the deprecation warnings from the CI), > will mark Oscar's for 'next' (if I haven't done so already), wait for > your updates and queue them on a topic forked from Oscar's (or on > the same Oscar's topic), and cook them for the first or the second > batch of the next cycle. Thank you for clarifying your intention, much appreciated. Ciao, Johannes ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-12-07 12:34 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55 ` Junio C Hamano
2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00 ` Junio C Hamano
2022-10-10 21:43 ` Junio C Hamano
2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-12-05 23:28 ` Junio C Hamano
2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21 ` Johannes Schindelin
2022-12-06 23:41 ` Junio C Hamano
2022-12-07 0:35 ` Junio C Hamano
2022-12-07 12:33 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).