git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Oscar Dominguez <dominguez.celada@gmail.com>
Subject: Re: [PATCH] ci: use actions/{upload,download}-artifact@v3
Date: Tue, 6 Dec 2022 22:21:23 +0100 (CET)	[thread overview]
Message-ID: <2s9ppo74-r654-231r-7ss7-o08464s2so6p@tzk.qr> (raw)
In-Reply-To: <xmqq1qpd9bys.fsf@gitster.g>

Hi Junio,

On Tue, 6 Dec 2022, Junio C Hamano wrote:

> GitHub CI jobs stopped complaining about use of deprecated actions
> that requires deprecated Node.js 12 for some steps, thanks to a
> recent work by Oscar Dominguez to upgrade actions/checkout from v2
> (which required Node.js 12) to v3 (which runs with recommended
> Node.js 16).
>
> Upgrade actions/upload-artifact and actions/download-artifact from
> v2 to v3, following suit.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  * The CI run hasn't finished, but it seems to be doing well
>    https://github.com/git/git/actions/runs/3627513480
>
>    We are also getting complaint about our use of set-output command
>    that is deprecated, which will need to be addressed, too.

See below.

>  .github/workflows/main.yml | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 5262823eb1..7a24c6613e 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -94,7 +94,7 @@ jobs:
>      - name: zip up tracked files
>        run: git archive -o artifacts/tracked.tar.gz HEAD
>      - name: upload tracked files and build artifacts
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v3
>        with:
>          name: windows-artifacts
>          path: artifacts
> @@ -108,7 +108,7 @@ jobs:
>          nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>      steps:
>      - name: download tracked files and build artifacts
> -      uses: actions/download-artifact@v2
> +      uses: actions/download-artifact@v3
>        with:
>          name: windows-artifacts
>          path: ${{github.workspace}}
> @@ -125,7 +125,7 @@ jobs:
>        run: ci/print-test-failures.sh
>      - name: Upload failed tests' directories
>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v3
>        with:
>          name: failed-tests-windows
>          path: ${{env.FAILED_TEST_ARTIFACTS}}
> @@ -177,7 +177,7 @@ jobs:
>      - name: zip up tracked files
>        run: git archive -o artifacts/tracked.tar.gz HEAD
>      - name: upload tracked files and build artifacts
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v3
>        with:
>          name: vs-artifacts
>          path: artifacts
> @@ -192,7 +192,7 @@ jobs:
>      steps:
>      - uses: git-for-windows/setup-git-for-windows-sdk@v1
>      - name: download tracked files and build artifacts
> -      uses: actions/download-artifact@v2
> +      uses: actions/download-artifact@v3
>        with:
>          name: vs-artifacts
>          path: ${{github.workspace}}
> @@ -210,7 +210,7 @@ jobs:
>        run: ci/print-test-failures.sh
>      - name: Upload failed tests' directories
>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v3

This is probably incorrect, but you wouldn't know until something failed
in the `linux32` job.

I already have a correct fix in
https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c
and was only waiting for the patch at the root of this here mail thread to
advance further so I could contribute that fix, along with other
replacements for deprecated operations.

Maybe we can move these changes forward in a more orderly manner, with
Oscar's patch advancing to `next` once it is done, and the other patches
following after that?

Ciao,
Johannes

>        with:
>          name: failed-tests-windows
>          path: ${{env.FAILED_TEST_ARTIFACTS}}
> @@ -267,7 +267,7 @@ jobs:
>        run: ci/print-test-failures.sh
>      - name: Upload failed tests' directories
>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v3
>        with:
>          name: failed-tests-${{matrix.vector.jobname}}
>          path: ${{env.FAILED_TEST_ARTIFACTS}}
> --
> 2.39.0-rc2
>
>
>

  reply	other threads:[~2022-12-06 21:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10  7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55   ` Junio C Hamano
2022-10-10  7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00   ` Junio C Hamano
2022-10-10 21:43   ` Junio C Hamano
2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-12-05 23:28   ` Junio C Hamano
2022-12-06  8:24   ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21     ` Johannes Schindelin [this message]
2022-12-06 23:41       ` Junio C Hamano
2022-12-07  0:35         ` Junio C Hamano
2022-12-07 12:33           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2s9ppo74-r654-231r-7ss7-o08464s2so6p@tzk.qr \
    --to=johannes.schindelin@gmx.de \
    --cc=dominguez.celada@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).