git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Oscar Dominguez <dominguez.celada@gmail.com>
Subject: Re: [PATCH v2] ci(main): upgrade actions/checkout to v3
Date: Tue, 06 Dec 2022 08:28:17 +0900	[thread overview]
Message-ID: <xmqqmt81ph0u.fsf@gitster.g> (raw)
In-Reply-To: <pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com> (Oscar Dominguez via GitGitGadget's message of "Mon, 05 Dec 2022 10:01:14 +0000")

"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> To be up to date with actions/checkout opens the door to use the latest
> features if necessary and get the latest security patches.
>
> This also avoids a couple of deprecation warnings in the CI runs.
>
> Note: The `actions/checkout` Action has been known to be broken in i686
> containers as of v2, therefore we keep forcing it to v1 there. See
> actions/runner#2115 for more details.
>
> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---

I do not know about Johannes, but the latter two S-o-b by others are
very questionable, as this is the first time I see this iteration of
the patch.  The chain of S-o-b is used to record that the author
handed the patch to somebody else who forwarded it to another
(i.e. the order of custody), and the above makes it look as if I
picked this iteration of your patch up, passed it to Johannes, and
he gave it to the mailing list readers with this message.

If you wanted to say "Input from Johannes helped me greatly while I
polished the earlier work to produce this version", it is more
appropriate to end the proposed log message with:

	Helped-by: Johannes Schindelin <...>
	Signed-off-by: Oscar Dominguez <...>

in chronological order.

In any case, I've been disturbed by the "Node 12 is going away, use
the one that works with Node 16" warning at GitHub CI for the past
few weeks and it is very welcome to see this topic moving forward.

Thanks for working on it.

  reply	other threads:[~2022-12-05 23:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10  7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55   ` Junio C Hamano
2022-10-10  7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00   ` Junio C Hamano
2022-10-10 21:43   ` Junio C Hamano
2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-12-05 23:28   ` Junio C Hamano [this message]
2022-12-06  8:24   ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21     ` Johannes Schindelin
2022-12-06 23:41       ` Junio C Hamano
2022-12-07  0:35         ` Junio C Hamano
2022-12-07 12:33           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmt81ph0u.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dominguez.celada@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).