git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* Not translatable strings in Git
@ 2017-05-06  8:40 Jordi Mas
  2017-05-08 16:49 ` Stefan Beller
  0 siblings, 1 reply; 4+ messages in thread
From: Jordi Mas @ 2017-05-06  8:40 UTC (permalink / raw)
  To: git

Hello,

When translating git (https://github.com/git/git/tree/master/po)

The following strings cannot be translated:

  remote: Counting objects: 331, done.
  remote: Compressing objects: 100% (213/213), done.
  remote: Total 244 (delta 184), reused 34 (delta 29)
  27 files changed, 3399 insertions(+), 3320 deletions(-)
  create mode 100644 build-aux/flatpak/org.gnome.Nautilus-stable.json
  delete mode 100755 build-aux/meson/check_libgd.sh

Since they are not in the PO files.

When working on making these strings localisable, I suggest checking 
that in the same modules there are other hardcoded strings that cannot 
be localised.

Thanks

Jordi,


---
This email has been checked for viruses by AVG.
http://www.avg.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Not translatable strings in Git
  2017-05-06  8:40 Not translatable strings in Git Jordi Mas
@ 2017-05-08 16:49 ` Stefan Beller
  2017-05-09  4:07   ` Jeff King
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Beller @ 2017-05-08 16:49 UTC (permalink / raw)
  To: Jordi Mas; +Cc: git@vger.kernel.org

On Sat, May 6, 2017 at 1:40 AM, Jordi Mas <jmas@softcatala.org> wrote:
> Hello,
>
> When translating git (https://github.com/git/git/tree/master/po)
>
> The following strings cannot be translated:
>
>  remote: Counting objects: 331, done.
>  remote: Compressing objects: 100% (213/213), done.
>  remote: Total 244 (delta 184), reused 34 (delta 29)

This is what the remote server tells a client, but the client did not
tell the server which locale it has.

Now consider we have hosting service that hosts projects accessible from
a wide range of users, all of them having different locales. Which language
should the remote speak? (Not knowing which language the client speaks).


>  27 files changed, 3399 insertions(+), 3320 deletions(-)
>  create mode 100644 build-aux/flatpak/org.gnome.Nautilus-stable.json
>  delete mode 100755 build-aux/meson/check_libgd.sh

These sound like they are done locally and could be translated easily.
However I wonder if we have issues with leaky plumbing in the user porcelain.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Not translatable strings in Git
  2017-05-08 16:49 ` Stefan Beller
@ 2017-05-09  4:07   ` Jeff King
  2017-05-09  4:31     ` Junio C Hamano
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff King @ 2017-05-09  4:07 UTC (permalink / raw)
  To: Stefan Beller; +Cc: Jordi Mas, git@vger.kernel.org

On Mon, May 08, 2017 at 09:49:34AM -0700, Stefan Beller wrote:

> On Sat, May 6, 2017 at 1:40 AM, Jordi Mas <jmas@softcatala.org> wrote:
> > Hello,
> >
> > When translating git (https://github.com/git/git/tree/master/po)
> >
> > The following strings cannot be translated:
> >
> >  remote: Counting objects: 331, done.
> >  remote: Compressing objects: 100% (213/213), done.
> >  remote: Total 244 (delta 184), reused 34 (delta 29)
> 
> This is what the remote server tells a client, but the client did not
> tell the server which locale it has.
> 
> Now consider we have hosting service that hosts projects accessible from
> a wide range of users, all of them having different locales. Which language
> should the remote speak? (Not knowing which language the client speaks).

In theory the client could pass the locale variables. We probably
already do by default over ssh. Likewise we could ask curl to send an
HTTP header based on the current locale, and the server could respect
that. That probably wouldn't even be that much code. I think it's just
something that nobody has bothered to implement so far.

> >  27 files changed, 3399 insertions(+), 3320 deletions(-)
> >  create mode 100644 build-aux/flatpak/org.gnome.Nautilus-stable.json
> >  delete mode 100755 build-aux/meson/check_libgd.sh
> 
> These sound like they are done locally and could be translated easily.
> However I wonder if we have issues with leaky plumbing in the user porcelain.

I don't think the diffstat summary is marked for translation at all,
plumbing or not.  There's some history there:

  http://public-inbox.org/git/1345922816-20616-1-git-send-email-pclouds@gmail.com/t/#u

There was an attempt to re-enable it for local-only commands:

  http://public-inbox.org/git/alpine.DEB.2.00.1210231323480.602@ds9.cixit.se/

but nobody seems to have responded (I don't have much of an opinion
myself).

-Peff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Not translatable strings in Git
  2017-05-09  4:07   ` Jeff King
@ 2017-05-09  4:31     ` Junio C Hamano
  0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2017-05-09  4:31 UTC (permalink / raw)
  To: Jeff King; +Cc: Stefan Beller, Jordi Mas, git@vger.kernel.org

Jeff King <peff@peff.net> writes:

> I don't think the diffstat summary is marked for translation at all,
> plumbing or not.  There's some history there:
>
>   http://public-inbox.org/git/1345922816-20616-1-git-send-email-pclouds@gmail.com/t/#u

Wow, that's a long thread.

> There was an attempt to re-enable it for local-only commands:
>
>   http://public-inbox.org/git/alpine.DEB.2.00.1210231323480.602@ds9.cixit.se/
>
> but nobody seems to have responded (I don't have much of an opinion
> myself).

I still think that the latter is wrong, especially the part that
touches log-tree.c, pp_header(), and other lower level things that
will be read and interpreted by scripts.  The change to diff.c about
the diffstat reverts a bugfix made in v1.8.0 timeperiod, it seems.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-05-09  4:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-06  8:40 Not translatable strings in Git Jordi Mas
2017-05-08 16:49 ` Stefan Beller
2017-05-09  4:07   ` Jeff King
2017-05-09  4:31     ` Junio C Hamano

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).