From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "dmh\@ucar.edu" <dmh@ucar.edu>, git@vger.kernel.org
Subject: Re: [PATCH 0/5] consistent setup code for external commands
Date: Fri, 01 Jul 2016 15:19:37 -0700 [thread overview]
Message-ID: <xmqq4m89vw5i.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160701055532.GA4488@sigill.intra.peff.net> (Jeff King's message of "Fri, 1 Jul 2016 01:55:32 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Jul 01, 2016 at 12:07:15AM -0400, Jeff King wrote:
>
>> Interesting. It's failing on the assert(argv0_path) in system_path().
>>
>> That's part of the RUNTIME_PREFIX code which is built only on Windows,
>> so this is a Windows-specific issue.
>>
>> I can guess the reason that argv0_path is not set is that
>> credential-store has its own main() function and does not call
>> git_extract_argv0_path(). It never mattered before, but as of v2.8.0,
>> one of the library functions it calls wants to use system_path(), which
>> assumes that the argv0 stuff has been set up.
>>
>> I'm preparing some patches to fix this case (and some other related
>> ones).
>
> Here they are:
>
> [1/5]: add an extra level of indirection to main()
> [2/5]: common-main: call git_extract_argv0_path()
> [3/5]: common-main: call sanitize_stdfds()
> [4/5]: common-main: call restore_sigpipe_to_default()
> [5/5]: common-main: call git_setup_gettext()
As this is also a fix to maint-2.8 track, I tweaked them to ensure
that they apply there, and queued the result as jk/common-main. I
double checked the result by comparing the result of applying these
five patches directly on top of master, and the result of merging
that jk/common-main (based on maint-2.8) into master, and they seem
to match.
Thanks.
next prev parent reply other threads:[~2016-07-01 22:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 21:24 git-credentials-store.exe crash dmh
2016-07-01 4:07 ` Jeff King
2016-07-01 5:55 ` [PATCH 0/5] consistent setup code for external commands Jeff King
2016-07-01 5:58 ` [PATCH 1/5] add an extra level of indirection to main() Jeff King
2016-07-01 8:04 ` Johannes Schindelin
2016-07-01 8:19 ` Jeff King
2016-07-01 13:39 ` Johannes Schindelin
2016-07-01 22:38 ` Jeff King
2016-07-02 6:52 ` Johannes Schindelin
2016-07-01 6:04 ` [PATCH 2/5] common-main: call git_extract_argv0_path() Jeff King
2016-07-01 8:05 ` Johannes Schindelin
2016-07-01 6:06 ` [PATCH 3/5] common-main: call sanitize_stdfds() Jeff King
2016-07-01 6:06 ` [PATCH 4/5] common-main: call restore_sigpipe_to_default() Jeff King
2016-07-01 6:07 ` [PATCH 5/5] common-main: call git_setup_gettext() Jeff King
2016-07-01 7:45 ` [PATCH 0/5] consistent setup code for external commands Johannes Schindelin
2016-07-01 22:19 ` Junio C Hamano [this message]
2016-07-01 22:39 ` Jeff King
2016-07-06 15:17 ` Junio C Hamano
2016-07-06 15:36 ` Johannes Schindelin
2016-07-01 7:38 ` git-credentials-store.exe crash Johannes Schindelin
2016-07-01 7:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4m89vw5i.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dmh@ucar.edu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).