From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: "dmh@ucar.edu" <dmh@ucar.edu>, git@vger.kernel.org
Subject: Re: [PATCH 1/5] add an extra level of indirection to main()
Date: Sat, 2 Jul 2016 08:52:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607020851060.12947@virtualbox> (raw)
In-Reply-To: <20160701223809.GA32545@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
Hi Peff,
On Fri, 1 Jul 2016, Jeff King wrote:
> On Fri, Jul 01, 2016 at 03:39:03PM +0200, Johannes Schindelin wrote:
>
> > > The description was sufficiently long that I didn't want to try
> > > repeating it, and opted for a reference instead. If you're planning to
> > > fix mingw_main(), I'd be happy to do that as a preparatory patch, and
> > > then just skip this trickery entirely. :)
> >
> > Deal:
> >
> > ½/5 is in 5c54dff5c54e68a1101d8fe37aefc6158fddd7f2 and the fixup for 1/5
> > is in 7b74f7aabb56b428c74f5983c066dc9ea8fe5116 in the 'common-main' branch
> > on https://github.com/dscho/git.
>
> Hrm. I didn't find 5c54dff5c when I fetched from dscho/git. However,
> having seen 7b74f7aa, the one that comes on top, I actually think that's
> what we really want anyway. It's really my first patch that makes your
> cleanup safe to do.
The reason is obvious: I forgot to push :-( Hopefully you did not
duplicate all my work to move my patch in front of the branch, to make it
a preparatory patch.
It is pushed now.
Sorry!
Dscho
next prev parent reply other threads:[~2016-07-02 6:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 21:24 git-credentials-store.exe crash dmh
2016-07-01 4:07 ` Jeff King
2016-07-01 5:55 ` [PATCH 0/5] consistent setup code for external commands Jeff King
2016-07-01 5:58 ` [PATCH 1/5] add an extra level of indirection to main() Jeff King
2016-07-01 8:04 ` Johannes Schindelin
2016-07-01 8:19 ` Jeff King
2016-07-01 13:39 ` Johannes Schindelin
2016-07-01 22:38 ` Jeff King
2016-07-02 6:52 ` Johannes Schindelin [this message]
2016-07-01 6:04 ` [PATCH 2/5] common-main: call git_extract_argv0_path() Jeff King
2016-07-01 8:05 ` Johannes Schindelin
2016-07-01 6:06 ` [PATCH 3/5] common-main: call sanitize_stdfds() Jeff King
2016-07-01 6:06 ` [PATCH 4/5] common-main: call restore_sigpipe_to_default() Jeff King
2016-07-01 6:07 ` [PATCH 5/5] common-main: call git_setup_gettext() Jeff King
2016-07-01 7:45 ` [PATCH 0/5] consistent setup code for external commands Johannes Schindelin
2016-07-01 22:19 ` Junio C Hamano
2016-07-01 22:39 ` Jeff King
2016-07-06 15:17 ` Junio C Hamano
2016-07-06 15:36 ` Johannes Schindelin
2016-07-01 7:38 ` git-credentials-store.exe crash Johannes Schindelin
2016-07-01 7:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607020851060.12947@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=dmh@ucar.edu \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).