git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: "dmh@ucar.edu" <dmh@ucar.edu>, git@vger.kernel.org
Subject: Re: [PATCH 0/5] consistent setup code for external commands
Date: Fri, 1 Jul 2016 09:45:58 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1607010939350.12947@virtualbox> (raw)
In-Reply-To: <20160701055532.GA4488@sigill.intra.peff.net>

Hi Peff,

On Fri, 1 Jul 2016, Jeff King wrote:

>   - for external programs run as "git foo", you get _two_ times.

I considered doing this in my work-around, but decided against it because
I deemed it too inelegant to call it twice.

But your patch series has more benefits than just fixing the assertion in
the credential-store.

For one, it makes test programs such as test-dump-untracked-cache.exe
usable outside Git's test suite without any major envvar jujitsu.

So once the dust settles, I will revert my commit in git-for-windows.git
and merge in your patches.

Thanks,
Dscho

  parent reply	other threads:[~2016-07-01  7:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 21:24 git-credentials-store.exe crash dmh
2016-07-01  4:07 ` Jeff King
2016-07-01  5:55   ` [PATCH 0/5] consistent setup code for external commands Jeff King
2016-07-01  5:58     ` [PATCH 1/5] add an extra level of indirection to main() Jeff King
2016-07-01  8:04       ` Johannes Schindelin
2016-07-01  8:19         ` Jeff King
2016-07-01 13:39           ` Johannes Schindelin
2016-07-01 22:38             ` Jeff King
2016-07-02  6:52               ` Johannes Schindelin
2016-07-01  6:04     ` [PATCH 2/5] common-main: call git_extract_argv0_path() Jeff King
2016-07-01  8:05       ` Johannes Schindelin
2016-07-01  6:06     ` [PATCH 3/5] common-main: call sanitize_stdfds() Jeff King
2016-07-01  6:06     ` [PATCH 4/5] common-main: call restore_sigpipe_to_default() Jeff King
2016-07-01  6:07     ` [PATCH 5/5] common-main: call git_setup_gettext() Jeff King
2016-07-01  7:45     ` Johannes Schindelin [this message]
2016-07-01 22:19     ` [PATCH 0/5] consistent setup code for external commands Junio C Hamano
2016-07-01 22:39       ` Jeff King
2016-07-06 15:17         ` Junio C Hamano
2016-07-06 15:36           ` Johannes Schindelin
2016-07-01  7:38   ` git-credentials-store.exe crash Johannes Schindelin
2016-07-01  7:43     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1607010939350.12947@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=dmh@ucar.edu \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).