From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: dmh@ucar.edu, git@vger.kernel.org
Subject: Re: git-credentials-store.exe crash
Date: Fri, 1 Jul 2016 03:43:54 -0400 [thread overview]
Message-ID: <20160701074354.GA12006@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1607010938140.12947@virtualbox>
On Fri, Jul 01, 2016 at 09:38:33AM +0200, Johannes Schindelin wrote:
> it is sad when bug reporters simply delete the part of our bug reporting
> template that says: "I searched for existing bug reports but did not find
> any".
>
> It saves the reporters a few minutes... and spends the time of you and me
> in the hour range.
>
> In this particular case, the bug report is an obvious duplicate of
> https://github.com/git-for-windows/git/issues/766
>
> The saddest part is that I already spent time to investigate this and to
> come up with a work-around, and I already committed and pushed it.
>
> So those hours are now thoroughly wasted.
Yeah, you're right. Same bug, and your patch obviously is the right
thing to do as an immediate fix.
If it's any consolation, I diagnosed the bug quite quickly, and the
extra hours went to solving the greater problem that you mentioned in
https://github.com/git-for-windows/git/issues/766#issuecomment-226985175.
So hopefully there is still some value in my series.
-Peff
prev parent reply other threads:[~2016-07-01 7:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 21:24 git-credentials-store.exe crash dmh
2016-07-01 4:07 ` Jeff King
2016-07-01 5:55 ` [PATCH 0/5] consistent setup code for external commands Jeff King
2016-07-01 5:58 ` [PATCH 1/5] add an extra level of indirection to main() Jeff King
2016-07-01 8:04 ` Johannes Schindelin
2016-07-01 8:19 ` Jeff King
2016-07-01 13:39 ` Johannes Schindelin
2016-07-01 22:38 ` Jeff King
2016-07-02 6:52 ` Johannes Schindelin
2016-07-01 6:04 ` [PATCH 2/5] common-main: call git_extract_argv0_path() Jeff King
2016-07-01 8:05 ` Johannes Schindelin
2016-07-01 6:06 ` [PATCH 3/5] common-main: call sanitize_stdfds() Jeff King
2016-07-01 6:06 ` [PATCH 4/5] common-main: call restore_sigpipe_to_default() Jeff King
2016-07-01 6:07 ` [PATCH 5/5] common-main: call git_setup_gettext() Jeff King
2016-07-01 7:45 ` [PATCH 0/5] consistent setup code for external commands Johannes Schindelin
2016-07-01 22:19 ` Junio C Hamano
2016-07-01 22:39 ` Jeff King
2016-07-06 15:17 ` Junio C Hamano
2016-07-06 15:36 ` Johannes Schindelin
2016-07-01 7:38 ` git-credentials-store.exe crash Johannes Schindelin
2016-07-01 7:43 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701074354.GA12006@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=dmh@ucar.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).