mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <>
To: Jeff King <>
Cc: Sibi Siddharthan <>,
	Junio C Hamano <>,
Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3)
Date: Fri, 14 Aug 2020 14:08:28 +0200 (CEST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Peff,

On Wed, 12 Aug 2020, Jeff King wrote:

> From my perspective as somebody who does not work on Windows, I wonder
> how much value there is in running vsbuild _and_ Windows CI for average
> developers. I have certainly gotten information from these jobs (e.g.,
> when introducing a portability problem, or missing a refactoring spot in
> Windows-only code). But I don't think I've ever gotten information from
> vsbuild that wasn't also in the regular windows build.

There have not been a _ton_ of these instances, but there have been a

2049b8dc65e (diffcore_rename(): use a stable sort, 2019-09-30)

	Here, MSVC pointed out that `qsort()` does not need to be stable,
	yet our test suite claimed that we expect it to be.

116d1fa6c69 (vreportf(): avoid relying on stdio buffering, 2019-10-30)

	MSVC's code demonstrated that `fprintf()` prints out messages
	character by character.

c097b95a260 (msvc: avoid using minus operator on unsigned types, 2019-10-04)

	We relied on some iffy behavior of GNU C which allows negating
	unsigned values (which cannot work if the high bit is set

dbcd970c27b (push: do not pretend to return `int` from
		`die_push_simple()`, 2019-09-30)

	A non-void return type in a noreturn function is bogus.

fdda1ac62d7 (t0001 (mingw): do not expect a specific order of
		stdout/stderr, 2019-06-19)

	A test that might even have been flaky on Linux failed frequently
	due to an incorrect assumption whether `stdout` would be flushed
	before `stderr`.

I cannot find any more instances, so yes, I agree that the
`vs-build`/`vs-test` jobs might not be _all_ that necessary. So maybe we
should do something like this?

-- snipsnap --
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 30425404eb3..2549fff8edd 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -122,7 +122,7 @@ jobs:
         path: ${{env.FAILED_TEST_ARTIFACTS}}
     needs: ci-config
-    if: == 'yes'
+    if: (github.repository == 'git/git' || github.repository == 'gitgitgadget/git') && == 'yes'
       NO_PERL: 1

  parent reply	other threads:[~2020-08-14 12:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  5:35 What's cooking in git.git (Aug 2020, #01; Mon, 3) Junio C Hamano
2020-08-04 18:50 ` Jeff King
2020-08-04 18:58   ` Junio C Hamano
2020-08-04 19:20     ` Jeff King
2020-08-12 13:35       ` Johannes Schindelin
2020-08-12 14:19         ` Jeff King
2020-08-12 15:56           ` Sibi Siddharthan
2020-08-12 16:06             ` Jeff King
2020-08-12 19:53               ` Junio C Hamano
2020-08-12 20:11                 ` Jeff King
2020-08-14 12:08               ` Johannes Schindelin [this message]
2020-08-14 12:40                 ` Jeff King
2020-08-17  4:41                   ` Johannes Schindelin
2020-08-17 17:19                   ` Junio C Hamano
2020-08-06  3:25 ` Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).