From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Sibi Siddharthan <sibisiv.siddharthan@gmail.com>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3)
Date: Wed, 12 Aug 2020 15:35:06 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2008121516560.50@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20200804192053.GA1400936@coredump.intra.peff.net>
Hi Peff,
On Tue, 4 Aug 2020, Jeff King wrote:
> On Tue, Aug 04, 2020 at 11:58:43AM -0700, Junio C Hamano wrote:
>
> > > I ran into issues with this, as I have several in-progress topics (not
> > > yet sent to the list) that touch our Makefile, and they needed updates
> > > to the cmake file (because it reproduces a lot of the lists and logic
> > > from the Makefile).
> > >
> > > The original philosophy behind putting it in contrib is that most people
> > > wouldn't have to care, and folks interested in cmake would be
> > > responsible for keeping it up to date. But the top patch makes it hard
> > > to ignore, because the vs-build CI job will fail.
> > >
> > > I'm not sure of the right path forward. I was definitely unenthused to
> > > be dealing with cmake, and the problem came up as soon as the series hit
> > > next.
> >
> > My hope is that if we let vs-build broken long enough, those who
> > want to see cmake to graduate would fix it. We can always threaten
> > the topic to be discarded out of 'next' after the next release if it
> > hasn't been fixed ;-)
>
> That was my philosophy, too, but it's annoying in the meantime as I get
> a notification for "your build is broken" every time I run CI. So it
> becomes a game of chicken over who gets annoyed first. ;)
I am a bit sad to read all this, as I thought that we had reached
consensus that the `Makefile` _is_ the source of truth.
But then, most of the source files that need to be compiled _are_ parsed
from the Makefile.
So I wonder what problems you ran into; Maybe we can come up with a
strategy how to preempt future instances of the same nature?
Ciao,
Dscho
next prev parent reply other threads:[~2020-08-12 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 5:35 What's cooking in git.git (Aug 2020, #01; Mon, 3) Junio C Hamano
2020-08-04 18:50 ` Jeff King
2020-08-04 18:58 ` Junio C Hamano
2020-08-04 19:20 ` Jeff King
2020-08-12 13:35 ` Johannes Schindelin [this message]
2020-08-12 14:19 ` Jeff King
2020-08-12 15:56 ` Sibi Siddharthan
2020-08-12 16:06 ` Jeff King
2020-08-12 19:53 ` Junio C Hamano
2020-08-12 20:11 ` Jeff King
2020-08-14 12:08 ` Johannes Schindelin
2020-08-14 12:40 ` Jeff King
2020-08-17 4:41 ` Johannes Schindelin
2020-08-17 17:19 ` Junio C Hamano
2020-08-06 3:25 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2008121516560.50@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sibisiv.siddharthan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).