From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Sibi Siddharthan <sibisiv.siddharthan@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3)
Date: Fri, 14 Aug 2020 08:40:11 -0400 [thread overview]
Message-ID: <20200814124011.GA4104592@coredump.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2008141352430.54@tvgsbejvaqbjf.bet>
On Fri, Aug 14, 2020 at 02:08:28PM +0200, Johannes Schindelin wrote:
> On Wed, 12 Aug 2020, Jeff King wrote:
>
> > From my perspective as somebody who does not work on Windows, I wonder
> > how much value there is in running vsbuild _and_ Windows CI for average
> > developers. I have certainly gotten information from these jobs (e.g.,
> > when introducing a portability problem, or missing a refactoring spot in
> > Windows-only code). But I don't think I've ever gotten information from
> > vsbuild that wasn't also in the regular windows build.
>
> There have not been a _ton_ of these instances, but there have been a
> couple:
Thanks, that was exactly the kind of data I was interested in.
> I cannot find any more instances, so yes, I agree that the
> `vs-build`/`vs-test` jobs might not be _all_ that necessary. So maybe we
> should do something like this?
Let's leave it be for now. The topics I had to adjust due to cmake were
ones that I'd had sitting around for a while. So while I hit problems
immediately, now that the queue is drained it's not clear to me how
often it will come up in practice.
> -- snipsnap --
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 30425404eb3..2549fff8edd 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -122,7 +122,7 @@ jobs:
> path: ${{env.FAILED_TEST_ARTIFACTS}}
> vs-build:
> needs: ci-config
> - if: needs.ci-config.outputs.enabled == 'yes'
> + if: (github.repository == 'git/git' || github.repository == 'gitgitgadget/git') && needs.ci-config.outputs.enabled == 'yes'
If we do go this route, I'd consider defaulting it to on and just
letting people disable it through needs.ci-config.outputs.vsbuild or
similar.
-Peff
next prev parent reply other threads:[~2020-08-14 12:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 5:35 What's cooking in git.git (Aug 2020, #01; Mon, 3) Junio C Hamano
2020-08-04 18:50 ` Jeff King
2020-08-04 18:58 ` Junio C Hamano
2020-08-04 19:20 ` Jeff King
2020-08-12 13:35 ` Johannes Schindelin
2020-08-12 14:19 ` Jeff King
2020-08-12 15:56 ` Sibi Siddharthan
2020-08-12 16:06 ` Jeff King
2020-08-12 19:53 ` Junio C Hamano
2020-08-12 20:11 ` Jeff King
2020-08-14 12:08 ` Johannes Schindelin
2020-08-14 12:40 ` Jeff King [this message]
2020-08-17 4:41 ` Johannes Schindelin
2020-08-17 17:19 ` Junio C Hamano
2020-08-06 3:25 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814124011.GA4104592@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sibisiv.siddharthan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).