mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <>
To: Sibi Siddharthan <>
Cc: Johannes Schindelin <>,
	Junio C Hamano <>,
Subject: Re: What's cooking in git.git (Aug 2020, #01; Mon, 3)
Date: Wed, 12 Aug 2020 12:06:53 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Aug 12, 2020 at 09:26:05PM +0530, Sibi Siddharthan wrote:

> The CMake script was not intended to be a write once and forget
> situation, it tries to pull from the Makefile as much
> as possible. A few changes are needed, which I intend to do.

Yeah, I know. My main beef was that because it fails CI, the urgency of
doing that fix gets pushed onto people working on their individual
topics (in fact there is nothing for you to fix yet because I haven't
even sent these topics upstream). I don't know how to solve that without
stopping its use in the vsbuild CI job, though. And clearly we need
_something_ to generate the build data for that job. So this may be the
last bad thing.

From my perspective as somebody who does not work on Windows, I wonder
how much value there is in running vsbuild _and_ Windows CI for average
developers. I have certainly gotten information from these jobs (e.g.,
when introducing a portability problem, or missing a refactoring spot in
Windows-only code). But I don't think I've ever gotten information from
vsbuild that wasn't also in the regular windows build.


  reply	other threads:[~2020-08-12 16:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  5:35 What's cooking in git.git (Aug 2020, #01; Mon, 3) Junio C Hamano
2020-08-04 18:50 ` Jeff King
2020-08-04 18:58   ` Junio C Hamano
2020-08-04 19:20     ` Jeff King
2020-08-12 13:35       ` Johannes Schindelin
2020-08-12 14:19         ` Jeff King
2020-08-12 15:56           ` Sibi Siddharthan
2020-08-12 16:06             ` Jeff King [this message]
2020-08-12 19:53               ` Junio C Hamano
2020-08-12 20:11                 ` Jeff King
2020-08-14 12:08               ` Johannes Schindelin
2020-08-14 12:40                 ` Jeff King
2020-08-17  4:41                   ` Johannes Schindelin
2020-08-17 17:19                   ` Junio C Hamano
2020-08-06  3:25 ` Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).