From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Nirmal Khedkar <nirmalhk7@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: Facing error in git-imap-send while compiling Git
Date: Fri, 17 Jan 2020 14:35:56 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2001171433180.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <CAFFaXsz9LEdegzxL8MhS+VfTs-wmWu+CGDjxjB4Xgj8+7nSHNQ@mail.gmail.com>
Hi Nirmal,
On Fri, 17 Jan 2020, Nirmal Khedkar wrote:
> On Fri, Jan 17, 2020 at 4:21 AM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Nirmal Khedkar <nirmalhk7@gmail.com> writes:
> >
> > > Hey!
> > > I've been facing this error everytime I run the Makefile:
> > > -----
> > > LINK git-imap-send
> > > imap-send.o: In function `verify_hostname':
> > > /git/imap-send.c:252: undefined reference to `sk_num'
> >
> > Perhaps the thread
> >
> > https://lore.kernel.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com
> >
> > may help?
>
> It did, to the extent that I now know why I'm facing these errors out
> of the blue.
>
> I'm not quite sure as to what am I supposed to do right now, should I
> wait for Liam's patch to be merged, or should I implement his fixes
> locally or should I just downgrade my openssl?
>
> Liam's PR (#516 on GitGitGadget [1]) haven't yet passed all build
> checks and I guess its still a work in progress. Nevertheless I've
> tried implementing his fixes to imap-send.c, and the make still fails.
> Am I missing something here?
Speaking for myself, I am still waiting for
https://public-inbox.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com/
to be addressed adequately. I think this is the main blocker.
You could be that person who addresses this, as already 10 days went past
without even so much as an acknowledgement of Junio's suggestion. Maybe
you can make it work, and submit a fixed patch (You could take authorship
and add a footer "Original-patch-by: Liam Huang <liamhuang0205@gmail.com>"
because it is most likely a total rewrite of Liam's patch).
Ciao,
Johannes
next prev parent reply other threads:[~2020-01-17 13:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 19:20 Facing error in git-imap-send while compiling Git Nirmal Khedkar
2020-01-16 22:51 ` Junio C Hamano
2020-01-17 12:42 ` Nirmal Khedkar
2020-01-17 13:35 ` Johannes Schindelin [this message]
2020-01-20 19:12 ` Nirmal Khedkar
2020-01-20 21:35 ` Johannes Schindelin
2020-01-21 11:50 ` Nirmal Khedkar
2020-01-21 18:11 ` Junio C Hamano
2020-01-21 21:09 ` Johannes Schindelin
2020-01-22 19:20 ` Junio C Hamano
2020-01-30 20:26 ` Nirmal Khedkar
2020-01-30 23:03 ` Beat Bolli
2020-02-01 21:35 ` Johannes Schindelin
2020-02-15 14:00 ` Nirmal Khedkar
-- strict thread matches above, loose matches on Subject: below --
2020-02-17 9:30 Abhishek Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2001171433180.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nirmalhk7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).