mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: "Liam Huang via GitGitGadget" <>
Subject: Re: [PATCH 1/1] Update imap-send.c, fix incompatibilities with OpenSSL 1.1.x
Date: Tue, 07 Jan 2020 12:19:15 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Liam Huang via GitGitGadget's message of "Tue, 07 Jan 2020 10:02:56 +0000")

"Liam Huang via GitGitGadget" <> writes:

> From: Liam Huang <>
> Some APIs have been changed since OpenSSL 1.1.0, so fix incompatibilities with OpenSSL 1.1.x.

I wonder if the patch can be made a lot less noisy with something
along this line

        #if OPENSSL_VERSION_NUMBER < 0x10100000L
        #define OPENSSL_sk_num(x) sk_GENERAL_NAME_num(x)
        #define OPENSSL_sk_value(x,y) sk_GENERAL_NAME_value((x),(y))
        #define OPENSSL_sk_pop_free(x,y) sk_GENERAL_NAME_pop_free((x),(y))

which would allow you to reduce many #if/#else/#endif in the actual

  reply	other threads:[~2020-01-07 20:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 10:02 [PATCH 0/1] Update imap-send.c, fix incompatibilities with OpenSSL 1.1.x Liam Huang via GitGitGadget
2020-01-07 10:02 ` [PATCH 1/1] " Liam Huang via GitGitGadget
2020-01-07 20:19   ` Junio C Hamano [this message]
2020-01-07 12:19 ` [PATCH 0/1] " Johannes Schindelin
2020-01-07 17:01   ` Junio C Hamano
2020-01-07 18:48     ` Johannes Schindelin
2020-01-07 19:57       ` Junio C Hamano
2020-01-07 20:15         ` Junio C Hamano
2020-01-08 10:59           ` Johannes Schindelin
2020-01-08 16:09             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).