From: Junio C Hamano <email@example.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Nirmal Khedkar <firstname.lastname@example.org>, email@example.com
Subject: Re: Facing error in git-imap-send while compiling Git
Date: Wed, 22 Jan 2020 11:20:26 -0800 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
In-Reply-To: <nycvar.QRO.email@example.com> (Johannes Schindelin's message of "Tue, 21 Jan 2020 22:09:07 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> From my limited knowledge of OpenSSL libraries, I think the error has
>> more to do with 'SSL_library_init()' , which appears like a
>> constructor to the OpenSSL library. I found these emails regarding
>> "if" cases around this function. Please check out these patches:
>> 1. Rosen Penev:
> I remember that one. And I agreed with Junio that the documentation
> suggests that the call is _optional_, while the patch suggests that it
> would be _incorrect_ instead.
> And looking at
> https://www.openssl.org/docs/man1.1.1/man3/SSL_library_init.html suggests
> to me that it is still supported.
> Having said that, if I look at the headers installed for `libssl-dev`
> version `1.1.1-1ubuntu2.1~18.04.5` in my Ubuntu installation, I see that
> `/usr/include/openssl/ssl.h` defines that symbol as:
> # define SSL_library_init() OPENSSL_init_ssl(0, NULL)
> but _only_:
> # if OPENSSL_API_COMPAT < 0x10100000L
> So maybe that disagrees with the documentation that says that
> SSL_library_init() is optional?
> The curious thing is that `OPENSSL_API_COMPAT` is not even defined
> anywhere. So maybe it _is_ the right thing to also `#define
> SSL_library_init() (void)` in the diff you listed above?
> _Maybe_ guarded within `#ifndef SSL_library_init ... #endif` guards?
>> 2. eroen: https://firstname.lastname@example.org/
> That sounds like a good suggestion, too.
>> Are the fixes made in these patches relevant here. Please let me know
>> if I'm going wrong.
> Yes, both threads are relevant, and if you can reconcile them into a patch
> that makes Git compile with OpenSSL v1.1.1, I will try my best to review
> them (Cc: me, just in case).
I agree with the above reasoning and the suggestion given by Bates in
sounds like a reasonable one.
Thanks for digging and double-checking these two previous efforts,
and giving another round of thoughts on them.
next prev parent reply other threads:[~2020-01-22 19:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 19:20 Facing error in git-imap-send while compiling Git Nirmal Khedkar
2020-01-16 22:51 ` Junio C Hamano
2020-01-17 12:42 ` Nirmal Khedkar
2020-01-17 13:35 ` Johannes Schindelin
2020-01-20 19:12 ` Nirmal Khedkar
2020-01-20 21:35 ` Johannes Schindelin
2020-01-21 11:50 ` Nirmal Khedkar
2020-01-21 18:11 ` Junio C Hamano
2020-01-21 21:09 ` Johannes Schindelin
2020-01-22 19:20 ` Junio C Hamano [this message]
2020-01-30 20:26 ` Nirmal Khedkar
2020-01-30 23:03 ` Beat Bolli
2020-02-01 21:35 ` Johannes Schindelin
2020-02-15 14:00 ` Nirmal Khedkar
2020-02-17 9:30 Abhishek Kumar
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).