git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Nirmal Khedkar <nirmalhk7@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: Facing error in git-imap-send while compiling Git
Date: Mon, 20 Jan 2020 22:35:25 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2001202232460.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <CAFFaXsyiLeNPCZ+Kn1x-+0pZf0FiPQR-k8qtooFrdG+VNfLq+g@mail.gmail.com>

Hi,

On Tue, 21 Jan 2020, Nirmal Khedkar wrote:

> On Fri, Jan 17, 2020 at 7:05 PM Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >
> > On Fri, 17 Jan 2020, Nirmal Khedkar wrote:
> >
> > > On Fri, Jan 17, 2020 at 4:21 AM Junio C Hamano <gitster@pobox.com> wrote:
> > > >
> > > > Nirmal Khedkar <nirmalhk7@gmail.com> writes:
> > > >
> > > > > Hey!
> > > > > I've been facing this error everytime I run the Makefile:
> > > > > -----
> > > > > LINK git-imap-send
> > > > > imap-send.o: In function `verify_hostname':
> > > > > /git/imap-send.c:252: undefined reference to `sk_num'
> > > >
> > > > Perhaps the thread
> > > >
> > > >   https://lore.kernel.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com
> > > >
> > > > may help?
> > >
> > > It did, to the extent that I now know why I'm facing these errors out
> > > of the blue.
> > >
> > > I'm  not quite sure as to what am I supposed to do right now, should I
> > > wait for Liam's patch to be merged,  or should I implement his fixes
> > > locally or should I just downgrade my openssl?
> > >
> > > Liam's PR (#516 on GitGitGadget [1]) haven't yet passed all build
> > > checks and I guess its still a work in progress. Nevertheless I've
> > > tried implementing his fixes to imap-send.c, and the make still fails.
> > > Am I missing something here?
> >
> > Speaking for myself, I am still waiting for
> > https://public-inbox.org/git/xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com/
> > to be addressed adequately. I think this is the main blocker.
> >
> > You could be that person who addresses this, as already 10 days went past
> > without even so much as an acknowledgement of Junio's suggestion. Maybe
> > you can make it work, and submit a fixed patch (You could take authorship
> > and add a footer "Original-patch-by: Liam Huang <liamhuang0205@gmail.com>"
> > because it is most likely a total rewrite of Liam's patch).
> >
> > Ciao,
> > Johannes
>
> The OpenSSL version on my system is 1.1.1. I've tried implementing
> Junio's suggestions, and it just doesn't work.

Does the code otherwise compile cleanly with `make DEVELOPER=1`?

> It gives me the same
> error as it gave me earlier. Here's the error:
> -----
> LINK git-imap-send
> imap-send.o: In function `verify_hostname':
> /git/imap-send.c:252: undefined reference to `sk_num'
> /git/imap-send.c:254: undefined reference to `sk_value'
> /git/imap-send.c:260: undefined reference to `sk_pop_free'
> /git/imap-send.c:260: undefined reference to `sk_pop_free'
> imap-send.o: In function `ssl_socket_connect':
> /git/imap-send.c:287: undefined reference to `SSL_library_init'
> /git/imap-send.c:288: undefined reference to `SSL_load_error_strings'
> /git/imap-send.c:290: undefined reference to `SSLv23_method'
> collect2: error: ld returned 1 exit status
>
> Makefile:2454: recipe for target 'git-imap-send' failed
> make: *** [git-imap-send] Error 1
> -----

Those are linker errors, meaning that the symbols were not found in the
libraries.

If you build with `make V=1 DEVELOPER=1` you should see that
`git-imap-send` links in OpenSSL via -lssl (and/or -lcrypto). Is this the
case for you?

Ciao,
Johannes

>
> From my limited understanding of OpenSSL API's, I reckon all these
> errors might be because of the errors around 'SSL_library_init' and
> 'SSL_load_error_strings'. Both these functions are called before
> 'verify_hostname' is ever called.
>
> StackOverflow suggested ([1]) to add tags during compilation, but I
> dont think that'd work here.
> What should I do? Would love it if you could guide me out.
>
>
> Thanks!
> Regards,
> Nirmal Khedkar
> https://nirmalhk7.github.io
>
> [1] https://stackoverflow.com/questions/5593284/undefined-reference-to-ssl-library-init-and-ssl-load-error-strings
>

  reply	other threads:[~2020-01-20 21:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 19:20 Facing error in git-imap-send while compiling Git Nirmal Khedkar
2020-01-16 22:51 ` Junio C Hamano
2020-01-17 12:42   ` Nirmal Khedkar
2020-01-17 13:35     ` Johannes Schindelin
2020-01-20 19:12       ` Nirmal Khedkar
2020-01-20 21:35         ` Johannes Schindelin [this message]
2020-01-21 11:50           ` Nirmal Khedkar
2020-01-21 18:11             ` Junio C Hamano
2020-01-21 21:09             ` Johannes Schindelin
2020-01-22 19:20               ` Junio C Hamano
2020-01-30 20:26                 ` Nirmal Khedkar
2020-01-30 23:03                   ` Beat Bolli
2020-02-01 21:35                   ` Johannes Schindelin
2020-02-15 14:00                     ` Nirmal Khedkar
  -- strict thread matches above, loose matches on Subject: below --
2020-02-17  9:30 Abhishek Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2001202232460.46@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nirmalhk7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).