From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
git@vger.kernel.org
Subject: [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2)
Date: Tue, 1 Apr 2008 13:38:55 +0200 [thread overview]
Message-ID: <cover.1207049697.git.vmiklos@frugalware.org> (raw)
In-Reply-To: <7vsky6jhz3.fsf@gitster.siamese.dyndns.org>
On Mon, Mar 31, 2008 at 09:51:12PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> > + return run_command(&hook);
> > +}
>
> Don't we want to distinguish between the case where start_command()
> failed, wait_or_whine() failed on waitpid(), the command was killed
> with
> signal, or the command actually ran correctly and decided that you
> should
> not run "git gc --auto" by exiting non-zero?
>
> I think it is prudent to refrain from running "git gc --auto" in any
> of
> the failure cases I listed above, but shouldn't the cases other than
> the
> last one at least issue a warning?
Ok, there are 3 cases here to handle. When wait_or_whine() fails on
waitpid() it already prints an error, so that's already handled. I've
added two warnings for the other 2 cases.
Other changes:
- try to use on_ac_power when it's available, as suggested by Joey Hess
- mention in the commend of the example pre-auto-gc hook that it's
Linux-specific, as suggested by Brian Gernhardt
- removed mentioning what the default hook does from hooks.txt, as it's
an example and it's under contrib/
- moved the battery example to contrib/ and added a minimal example to
templates/
- removed unnecessary stdout_to_stderr from builtin-gc.c::run_hook()
- removed unnecessary --no-verify option
I hope I haven't missed anything you suggested.
Miklos Vajna (4):
git-gc --auto: add pre-auto-gc hook
Documentation/hooks: add pre-auto-gc hook
templates: add an example pre-auto-gc hook
contrib/hooks: add an example pre-auto-gc hook
Documentation/hooks.txt | 7 +++++
builtin-gc.c | 30 ++++++++++++++++++++++++
contrib/hooks/pre-auto-gc-battery | 45 +++++++++++++++++++++++++++++++++++++
templates/hooks--pre-auto-gc | 9 +++++++
4 files changed, 91 insertions(+), 0 deletions(-)
create mode 100644 contrib/hooks/pre-auto-gc-battery
create mode 100644 templates/hooks--pre-auto-gc
next prev parent reply other threads:[~2008-04-01 11:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos @frugalware.org>
2008-04-01 4:51 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Junio C Hamano
2008-04-01 11:38 ` Miklos Vajna [this message]
2008-04-01 23:18 ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2) Junio C Hamano
2008-04-02 1:14 ` Miklos Vajna
2008-04-02 4:02 ` Junio C Hamano
2008-04-02 19:02 ` Miklos Vajna
2008-04-02 19:07 ` Junio C Hamano
2008-04-02 19:34 ` [PATCH 0/3] add pre-auto-gc hook for git-gc --auto (try3) Miklos Vajna
2008-04-02 19:34 ` [PATCH 1/3] git-gc --auto: add pre-auto-gc hook Miklos Vajna
2008-04-02 19:34 ` [PATCH 2/3] Documentation/hooks: " Miklos Vajna
2008-04-02 19:35 ` [PATCH 3/3] contrib/hooks: add an example " Miklos Vajna
2008-04-02 19:49 ` Junio C Hamano
2008-04-02 20:22 ` Miklos Vajna
2008-04-02 20:34 ` Junio C Hamano
2008-04-02 20:45 ` Miklos Vajna
2008-04-03 21:26 ` tests for pre-auto-gc hook (WAS: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook) Miklos Vajna
2008-04-04 6:34 ` tests for pre-auto-gc hook Johannes Sixt
2008-04-01 11:39 ` [PATCH 1/4] git-gc --auto: add " Miklos Vajna
2008-04-01 11:39 ` [PATCH 2/4] Documentation/hooks: " Miklos Vajna
2008-04-01 11:39 ` [PATCH 3/4] templates: add an example " Miklos Vajna
2008-04-01 11:39 ` [PATCH 4/4] contrib/hooks: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1207049697.git.vmiklos@frugalware.org \
--to=vmiklos@frugalware.org \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).