From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook
Date: Wed, 02 Apr 2008 13:34:27 -0700 [thread overview]
Message-ID: <7vfxu4808c.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <96017502f7bca67a14f9a09d19c8ea42bde78949.1207167342.git.vmiklos@frugalware.org> (Miklos Vajna's message of "Wed, 2 Apr 2008 22:22:21 +0200")
Miklos Vajna <vmiklos@frugalware.org> writes:
> Hm, I must be crazy when I wrote this. It has three exit codes:
>
> 0 if on AC power
> 1 if not on AC power
> 255 if can't tell
>
> So IMHO the right think to do is to check if the return value is != 1,
> and if that's true, then do an exit 0.
If it is "can't tell", then it is "can't tell". Don't you want to err on
the safe side?
next prev parent reply other threads:[~2008-04-02 20:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos @frugalware.org>
2008-04-01 4:51 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Junio C Hamano
2008-04-01 11:38 ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2) Miklos Vajna
2008-04-01 23:18 ` Junio C Hamano
2008-04-02 1:14 ` Miklos Vajna
2008-04-02 4:02 ` Junio C Hamano
2008-04-02 19:02 ` Miklos Vajna
2008-04-02 19:07 ` Junio C Hamano
2008-04-02 19:34 ` [PATCH 0/3] add pre-auto-gc hook for git-gc --auto (try3) Miklos Vajna
2008-04-02 19:34 ` [PATCH 1/3] git-gc --auto: add pre-auto-gc hook Miklos Vajna
2008-04-02 19:34 ` [PATCH 2/3] Documentation/hooks: " Miklos Vajna
2008-04-02 19:35 ` [PATCH 3/3] contrib/hooks: add an example " Miklos Vajna
2008-04-02 19:49 ` Junio C Hamano
2008-04-02 20:22 ` Miklos Vajna
2008-04-02 20:34 ` Junio C Hamano [this message]
2008-04-02 20:45 ` Miklos Vajna
2008-04-03 21:26 ` tests for pre-auto-gc hook (WAS: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook) Miklos Vajna
2008-04-04 6:34 ` tests for pre-auto-gc hook Johannes Sixt
2008-04-01 11:39 ` [PATCH 1/4] git-gc --auto: add " Miklos Vajna
2008-04-01 11:39 ` [PATCH 2/4] Documentation/hooks: " Miklos Vajna
2008-04-01 11:39 ` [PATCH 3/4] templates: add an example " Miklos Vajna
2008-04-01 11:39 ` [PATCH 4/4] contrib/hooks: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxu4808c.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).