From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
git@vger.kernel.org
Subject: [PATCH 1/3] git-gc --auto: add pre-auto-gc hook
Date: Wed, 2 Apr 2008 21:34:38 +0200 [thread overview]
Message-ID: <4507d1e1d8973a621222c389fa22cd96266312a7.1207164676.git.vmiklos@frugalware.org> (raw)
In-Reply-To: <7vtzik848t.fsf@gitster.siamese.dyndns.org>
If such a hook is available and exits with a non-zero status, then
git-gc --auto won't run.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
builtin-gc.c | 31 +++++++++++++++++++++++++++++++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/builtin-gc.c b/builtin-gc.c
index 8cef36f..9dc7a37 100644
--- a/builtin-gc.c
+++ b/builtin-gc.c
@@ -157,6 +157,34 @@ static int too_many_packs(void)
return gc_auto_pack_limit <= cnt;
}
+static int run_hook()
+{
+ const char *argv[2];
+ struct child_process hook;
+ int ret;
+
+ argv[0] = git_path("hooks/pre-auto-gc");
+ argv[1] = NULL;
+
+ if (access(argv[0], X_OK) < 0)
+ return 0;
+
+ memset(&hook, 0, sizeof(hook));
+ hook.argv = argv;
+ hook.no_stdin = 1;
+ hook.stdout_to_stderr = 1;
+
+ ret = start_command(&hook);
+ if (ret) {
+ warning("Could not spawn %s", argv[0]);
+ return ret;
+ }
+ ret = finish_command(&hook);
+ if (ret == -ERR_RUN_COMMAND_WAITPID_SIGNAL)
+ warning("%s exited due to uncaught signal", argv[0]);
+ return ret;
+}
+
static int need_to_gc(void)
{
/*
@@ -176,6 +204,9 @@ static int need_to_gc(void)
append_option(argv_repack, "-A", MAX_ADD);
else if (!too_many_loose_objects())
return 0;
+
+ if (run_hook())
+ return 0;
return 1;
}
--
1.5.5.rc2.4.gec07.dirty
next prev parent reply other threads:[~2008-04-02 19:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos @frugalware.org>
2008-04-01 4:51 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Junio C Hamano
2008-04-01 11:38 ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2) Miklos Vajna
2008-04-01 23:18 ` Junio C Hamano
2008-04-02 1:14 ` Miklos Vajna
2008-04-02 4:02 ` Junio C Hamano
2008-04-02 19:02 ` Miklos Vajna
2008-04-02 19:07 ` Junio C Hamano
2008-04-02 19:34 ` [PATCH 0/3] add pre-auto-gc hook for git-gc --auto (try3) Miklos Vajna
2008-04-02 19:34 ` Miklos Vajna [this message]
2008-04-02 19:34 ` [PATCH 2/3] Documentation/hooks: add pre-auto-gc hook Miklos Vajna
2008-04-02 19:35 ` [PATCH 3/3] contrib/hooks: add an example " Miklos Vajna
2008-04-02 19:49 ` Junio C Hamano
2008-04-02 20:22 ` Miklos Vajna
2008-04-02 20:34 ` Junio C Hamano
2008-04-02 20:45 ` Miklos Vajna
2008-04-03 21:26 ` tests for pre-auto-gc hook (WAS: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook) Miklos Vajna
2008-04-04 6:34 ` tests for pre-auto-gc hook Johannes Sixt
2008-04-01 11:39 ` [PATCH 1/4] git-gc --auto: add " Miklos Vajna
2008-04-01 11:39 ` [PATCH 2/4] Documentation/hooks: " Miklos Vajna
2008-04-01 11:39 ` [PATCH 3/4] templates: add an example " Miklos Vajna
2008-04-01 11:39 ` [PATCH 4/4] contrib/hooks: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4507d1e1d8973a621222c389fa22cd96266312a7.1207164676.git.vmiklos@frugalware.org \
--to=vmiklos@frugalware.org \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).