From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
git@vger.kernel.org
Subject: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook
Date: Wed, 2 Apr 2008 22:22:21 +0200 [thread overview]
Message-ID: <96017502f7bca67a14f9a09d19c8ea42bde78949.1207167342.git.vmiklos@frugalware.org> (raw)
In-Reply-To: <7vk5jg82b7.fsf@gitster.siamese.dyndns.org>
It disables git-gc --auto when you are running Linux and you are on
battery.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
On Wed, Apr 02, 2008 at 12:49:32PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> Miklos Vajna <vmiklos@frugalware.org> writes:
>
> > +if test -x /sbin/on_ac_power && /sbin/on_ac_power
> > +then
> > + /sbin/on_ac_power
> > + if [ $? = 1 ]; then
> > + exit 0
> > + fi
>
> Shouldn't the above be:
>
> if test -x /sbin/on_ac_power && /sbin/on_ac_power
> then
> exit 0
>
> That is, you checked if you have the command to check
> on-ac-power-ness,
> and the command says yes, so you happily let "gc --auto" do its thing.
Hm, I must be crazy when I wrote this. It has three exit codes:
0 if on AC power
1 if not on AC power
255 if can't tell
So IMHO the right think to do is to check if the return value is != 1,
and if that's true, then do an exit 0.
Here is try4.
contrib/hooks/pre-auto-gc-battery | 40 +++++++++++++++++++++++++++++++++++++
1 files changed, 40 insertions(+), 0 deletions(-)
create mode 100644 contrib/hooks/pre-auto-gc-battery
diff --git a/contrib/hooks/pre-auto-gc-battery b/contrib/hooks/pre-auto-gc-battery
new file mode 100644
index 0000000..c6af057
--- /dev/null
+++ b/contrib/hooks/pre-auto-gc-battery
@@ -0,0 +1,40 @@
+#!/bin/sh
+#
+# An example hook script to verify if you are on battery, in case you
+# are running Linux. Called by git-gc --auto with no arguments. The hook
+# should exit with non-zero status after issuing an appropriate message
+# if it wants to stop the auto repacking.
+#
+# This hook is stored in the contrib/hooks directory. Your distribution
+# may have put this somewhere else. If you want to use this hook, you
+# should make this script executable then link to it in the repository
+# you would like to use it in.
+#
+# For example, if the hook is stored in
+# /usr/share/git-core/contrib/hooks/pre-auto-gc-battery:
+#
+# chmod a+x pre-auto-gc-battery
+# cd /path/to/your/repository.git
+# ln -sf /usr/share/git-core/contrib/hooks/pre-auto-gc-battery \
+# hooks/pre-auto-gc
+
+if test -x /sbin/on_ac_power
+then
+ /sbin/on_ac_power
+ if test $? -ne 1
+ then
+ exit 0
+ fi
+elif test "$(cat /sys/class/power_supply/AC/online 2>/dev/null)" = 1
+then
+ exit 0
+elif grep -q 'on-line' /proc/acpi/ac_adapter/AC/state 2>/dev/null
+then
+ exit 0
+elif grep -q '0x01$' /proc/apm 2>/dev/null
+then
+ exit 0
+fi
+
+echo "Auto packing deferred; on battery"
+exit 1
--
1.5.5.rc2.4.gec07.dirty
next prev parent reply other threads:[~2008-04-02 20:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos @frugalware.org>
2008-04-01 4:51 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Junio C Hamano
2008-04-01 11:38 ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2) Miklos Vajna
2008-04-01 23:18 ` Junio C Hamano
2008-04-02 1:14 ` Miklos Vajna
2008-04-02 4:02 ` Junio C Hamano
2008-04-02 19:02 ` Miklos Vajna
2008-04-02 19:07 ` Junio C Hamano
2008-04-02 19:34 ` [PATCH 0/3] add pre-auto-gc hook for git-gc --auto (try3) Miklos Vajna
2008-04-02 19:34 ` [PATCH 1/3] git-gc --auto: add pre-auto-gc hook Miklos Vajna
2008-04-02 19:34 ` [PATCH 2/3] Documentation/hooks: " Miklos Vajna
2008-04-02 19:35 ` [PATCH 3/3] contrib/hooks: add an example " Miklos Vajna
2008-04-02 19:49 ` Junio C Hamano
2008-04-02 20:22 ` Miklos Vajna [this message]
2008-04-02 20:34 ` Junio C Hamano
2008-04-02 20:45 ` Miklos Vajna
2008-04-03 21:26 ` tests for pre-auto-gc hook (WAS: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook) Miklos Vajna
2008-04-04 6:34 ` tests for pre-auto-gc hook Johannes Sixt
2008-04-01 11:39 ` [PATCH 1/4] git-gc --auto: add " Miklos Vajna
2008-04-01 11:39 ` [PATCH 2/4] Documentation/hooks: " Miklos Vajna
2008-04-01 11:39 ` [PATCH 3/4] templates: add an example " Miklos Vajna
2008-04-01 11:39 ` [PATCH 4/4] contrib/hooks: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96017502f7bca67a14f9a09d19c8ea42bde78949.1207167342.git.vmiklos@frugalware.org \
--to=vmiklos@frugalware.org \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).