From: Derrick Stolee <stolee@gmail.com>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Derrick Stolee <dstolee@microsoft.com>,
Kevin.Willford@microsoft.com, Kyle Meyer <kyle@kyleam.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v3 2/4] dir: treat_leading_path() and read_directory_recursive(), round 2
Date: Fri, 17 Jan 2020 10:25:42 -0500 [thread overview]
Message-ID: <bd3892c6-98fb-d0eb-2e0a-f7d6971dd4d3@gmail.com> (raw)
In-Reply-To: <ea95186774762a5e1cf3cb882cff45fc904e3bf6.1579206117.git.gitgitgadget@gmail.com>
On 1/16/2020 3:21 PM, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
>
> I was going to title this "dir: more synchronizing of
> treat_leading_path() and read_directory_recursive()", a nod to commit
> 777b42034764 ("dir: synchronize treat_leading_path() and
> read_directory_recursive()", 2019-12-19), but the title was too long.
>
> Anyway, first the backstory...
The backstory was helpful, thanks.
> Copy the missing bits to fix the new final test in t7300.
Thanks for the quick turnaround!
-Stolee
next prev parent reply other threads:[~2020-01-17 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:32 [PATCH] dir: restructure in a way to avoid passing around a struct dirent Elijah Newren via GitGitGadget
2020-01-14 21:07 ` Johannes Schindelin
2020-01-14 21:13 ` Elijah Newren
2020-01-14 22:03 ` Jeff King
2020-01-15 14:21 ` [PATCH v2] " Elijah Newren via GitGitGadget
2020-01-15 20:21 ` [PATCH] dir: point treat_leading_path() warning to the right place Jeff King
2020-01-15 20:28 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 0/4] dir: more fill_directory() fixes Elijah Newren via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 1/4] clean: demonstrate a bug with pathspecs Derrick Stolee via GitGitGadget
2020-01-17 15:20 ` Derrick Stolee
2020-01-17 16:53 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 2/4] dir: treat_leading_path() and read_directory_recursive(), round 2 Elijah Newren via GitGitGadget
2020-01-17 15:25 ` Derrick Stolee [this message]
2020-01-16 20:21 ` [PATCH v3 3/4] dir: restructure in a way to avoid passing around a struct dirent Jeff King via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 4/4] dir: point treat_leading_path() warning to the right place Jeff King via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd3892c6-98fb-d0eb-2e0a-f7d6971dd4d3@gmail.com \
--to=stolee@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Kevin.Willford@microsoft.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jrnieder@gmail.com \
--cc=kyle@kyleam.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).