From: Elijah Newren <newren@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] dir: restructure in a way to avoid passing around a struct dirent
Date: Tue, 14 Jan 2020 13:13:10 -0800 [thread overview]
Message-ID: <CABPp-BEG-z4cQujWtvcfMPh8fDZeScbr=OLEW5FhXQKkFcjbWw@mail.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2001142203450.46@tvgsbejvaqbjf.bet>
Hi Dscho,
On Tue, Jan 14, 2020 at 1:07 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>
> Hi,
>
>
> On Tue, 14 Jan 2020, Elijah Newren via GitGitGadget wrote:
>
> > Restructure the code slightly to avoid passing around a struct dirent
> > anywhere, which also enables us to avoid trying to manufacture one.
>
> Please note that due a bug (which has been fixed in the meantime, see
> https://github.com/gitgitgadget/gitgitgadget/pull/188 for details), this
> GitGitGadget mail is missing the line
>
> From: Jeff King <peff@peff.net>
Thanks for the heads up. Once Peff provides his Signed-off-by, I'll
add it to the patch and resubmit which will hopefully fix both the
from and the signed-off-by at the same time.
> The patch itself looks fine to me.
>
> Thanks,
> Dscho
next prev parent reply other threads:[~2020-01-14 21:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:32 [PATCH] dir: restructure in a way to avoid passing around a struct dirent Elijah Newren via GitGitGadget
2020-01-14 21:07 ` Johannes Schindelin
2020-01-14 21:13 ` Elijah Newren [this message]
2020-01-14 22:03 ` Jeff King
2020-01-15 14:21 ` [PATCH v2] " Elijah Newren via GitGitGadget
2020-01-15 20:21 ` [PATCH] dir: point treat_leading_path() warning to the right place Jeff King
2020-01-15 20:28 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 0/4] dir: more fill_directory() fixes Elijah Newren via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 1/4] clean: demonstrate a bug with pathspecs Derrick Stolee via GitGitGadget
2020-01-17 15:20 ` Derrick Stolee
2020-01-17 16:53 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 2/4] dir: treat_leading_path() and read_directory_recursive(), round 2 Elijah Newren via GitGitGadget
2020-01-17 15:25 ` Derrick Stolee
2020-01-16 20:21 ` [PATCH v3 3/4] dir: restructure in a way to avoid passing around a struct dirent Jeff King via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 4/4] dir: point treat_leading_path() warning to the right place Jeff King via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABPp-BEG-z4cQujWtvcfMPh8fDZeScbr=OLEW5FhXQKkFcjbWw@mail.gmail.com' \
--to=newren@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).