From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Derrick Stolee <dstolee@microsoft.com>,
Kevin.Willford@microsoft.com, Kyle Meyer <kyle@kyleam.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Elijah Newren <newren@gmail.com>
Subject: [PATCH v3 0/4] dir: more fill_directory() fixes
Date: Thu, 16 Jan 2020 20:21:52 +0000 [thread overview]
Message-ID: <pull.692.v3.git.git.1579206117.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.692.v2.git.git.1579098078501.gitgitgadget@gmail.com>
This is a follow up to en/fill-directory-fixes, and has grown from 1 patch
in v1 to 4 patches in v2, 3 of which are submissions by others to the git
list that I've just combined into one series since they are all about
fill_directory().
The first two patches may make sense to include in maint at some point,
though Stolee isn't that concerned about this regression[5][6].
* The first patch is Kevin and Stolee's testcase showing a regression in
"git clean -f "[1]
* The second patch is a "simple" fix for that testcase with a pretty long
(and slightly embarrassing though entertaining) backstory.
* The third patch was from v1, and is a small tweak made by me to a patch
proposed by Peff[2] (signoff from [3]) to avoid needing to create a
dirent.
* The fourth patch was a follow-up from Peff in response to V1 fixing a
code comment[4].
[1]
https://lore.kernel.org/git/pull.526.git.1579119946211.gitgitgadget@gmail.com/
[2]
https://lore.kernel.org/git/20191219222403.GA705525@coredump.intra.peff.net/
[3]
https://lore.kernel.org/git/20200114220357.GA3957260@coredump.intra.peff.net/
[4]
https://lore.kernel.org/git/20200115202146.GA4091171@coredump.intra.peff.net/
[5]
https://lore.kernel.org/git/354fa43b-0e62-1ee5-a63f-59d9b2da7d3f@gmail.com/
[6]
https://lore.kernel.org/git/e008da66-defe-d2b0-410b-64b7754b9c6e@gmail.com/
Derrick Stolee (1):
clean: demonstrate a bug with pathspecs
Elijah Newren (1):
dir: treat_leading_path() and read_directory_recursive(), round 2
Jeff King (2):
dir: restructure in a way to avoid passing around a struct dirent
dir: point treat_leading_path() warning to the right place
dir.c | 83 ++++++++++++++++++++++--------------------------
t/t7300-clean.sh | 9 ++++++
2 files changed, 47 insertions(+), 45 deletions(-)
base-commit: d0654dc308b0ba76dd8ed7bbb33c8d8f7aacd783
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-692%2Fnewren%2Favoid-dirent-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-692/newren/avoid-dirent-v3
Pull-Request: https://github.com/git/git/pull/692
Range-diff vs v2:
-: ---------- > 1: 9efed585ef clean: demonstrate a bug with pathspecs
-: ---------- > 2: ea95186774 dir: treat_leading_path() and read_directory_recursive(), round 2
1: edb18304b2 = 3: 5b8fa6e5a7 dir: restructure in a way to avoid passing around a struct dirent
-: ---------- > 4: 9d346f8b6b dir: point treat_leading_path() warning to the right place
--
gitgitgadget
next prev parent reply other threads:[~2020-01-16 20:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:32 [PATCH] dir: restructure in a way to avoid passing around a struct dirent Elijah Newren via GitGitGadget
2020-01-14 21:07 ` Johannes Schindelin
2020-01-14 21:13 ` Elijah Newren
2020-01-14 22:03 ` Jeff King
2020-01-15 14:21 ` [PATCH v2] " Elijah Newren via GitGitGadget
2020-01-15 20:21 ` [PATCH] dir: point treat_leading_path() warning to the right place Jeff King
2020-01-15 20:28 ` Elijah Newren
2020-01-16 20:21 ` Elijah Newren via GitGitGadget [this message]
2020-01-16 20:21 ` [PATCH v3 1/4] clean: demonstrate a bug with pathspecs Derrick Stolee via GitGitGadget
2020-01-17 15:20 ` Derrick Stolee
2020-01-17 16:53 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 2/4] dir: treat_leading_path() and read_directory_recursive(), round 2 Elijah Newren via GitGitGadget
2020-01-17 15:25 ` Derrick Stolee
2020-01-16 20:21 ` [PATCH v3 3/4] dir: restructure in a way to avoid passing around a struct dirent Jeff King via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 4/4] dir: point treat_leading_path() warning to the right place Jeff King via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.692.v3.git.git.1579206117.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=Kevin.Willford@microsoft.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=kyle@kyleam.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).