From: Jeff King <peff@peff.net>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] dir: restructure in a way to avoid passing around a struct dirent
Date: Tue, 14 Jan 2020 17:03:57 -0500 [thread overview]
Message-ID: <20200114220357.GA3957260@coredump.intra.peff.net> (raw)
In-Reply-To: <pull.692.git.git.1579019532809.gitgitgadget@gmail.com>
On Tue, Jan 14, 2020 at 04:32:12PM +0000, Elijah Newren via GitGitGadget wrote:
> When I was more than a bit burned out on dir.c in late December, I had
> looked at making another change to remove the need for a dirent but
> punted because it looked like "way too much work". Junio and Peff both
> later suggested the same cleanup, but I said it was too much work. Peff
> posted a patch which demonstrated that it was actually pretty simple[1],
> but I somehow read his email wrong and assumed he was commenting on my
> patch (if I had looked even slightly closer...). His patch was actually
> for before en/fill-directory-fixes was applied, so I have updated it
> slightly to apply after that series.
Yeah, I hadn't really grokked your patch, so I was hoping you'd build
your stuff on top. :)
> I'm not sure if I'm supposed to add a Reviewed-by me or a Signed-off-by
> or both, but I read through it closely to avoid any hidden surprises. I
> probably could have saved Dscho some time last month if I would have
> just looked a little closer. Sorry about all that...
>
> (And yeah, we'll need Peff's Signed-off-by, since I'm leaving him as the
> author; I really only made a small tweak to update his patch.)
>
> CC: Jeff King peff@peff.net [peff@peff.net], Johannes Schindelin
> Johannes.Schindelin@gmx.de [Johannes.Schindelin@gmx.de]
Hmm, looks like you maybe meant for more headers (and cc's) to happen
than did. Anyway, I'm certainly fine with this direction, and you have
my:
Signed-off-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2020-01-14 22:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 16:32 [PATCH] dir: restructure in a way to avoid passing around a struct dirent Elijah Newren via GitGitGadget
2020-01-14 21:07 ` Johannes Schindelin
2020-01-14 21:13 ` Elijah Newren
2020-01-14 22:03 ` Jeff King [this message]
2020-01-15 14:21 ` [PATCH v2] " Elijah Newren via GitGitGadget
2020-01-15 20:21 ` [PATCH] dir: point treat_leading_path() warning to the right place Jeff King
2020-01-15 20:28 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 0/4] dir: more fill_directory() fixes Elijah Newren via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 1/4] clean: demonstrate a bug with pathspecs Derrick Stolee via GitGitGadget
2020-01-17 15:20 ` Derrick Stolee
2020-01-17 16:53 ` Elijah Newren
2020-01-16 20:21 ` [PATCH v3 2/4] dir: treat_leading_path() and read_directory_recursive(), round 2 Elijah Newren via GitGitGadget
2020-01-17 15:25 ` Derrick Stolee
2020-01-16 20:21 ` [PATCH v3 3/4] dir: restructure in a way to avoid passing around a struct dirent Jeff King via GitGitGadget
2020-01-16 20:21 ` [PATCH v3 4/4] dir: point treat_leading_path() warning to the right place Jeff King via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114220357.GA3957260@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).