From: David Lang <david@lang.hm>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: "Thiago Farina" <tfransosi@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Deniz Türkoglu" <deniz@spotify.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Shawn Pearce" <sop@google.com>
Subject: Re: Reviews on mailing-list
Date: Sun, 11 Nov 2012 13:15:08 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1211111313140.19687@nftneq.ynat.uz> (raw)
In-Reply-To: <20121111171451.GA26695@shrek.podlesie.net>
On Sun, 11 Nov 2012, Krzysztof Mazur wrote:
> On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote:
>> On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>> Requiring everyone to use a web browser would limit the amount of ways
>>> people can review patches.
>> I don't see that as a limitation as I think everyone has access to a
>> web browser these days, don't have?
>
> Almost everyone, but not everyone likes using web browser.
Using a web browser requires connectivity at the time you are doing the review.
Mailing list based reviews can be done at times when you don't have
connectivity.
Coincidently, one of the common times when people don't have connectivity is
when they are traveling, and this can be a good time to do things like code
review.
David Lang
next prev parent reply other threads:[~2012-11-11 21:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 23:19 Reviews on mailing-list Deniz Türkoglu
2012-11-10 23:40 ` Felipe Contreras
2012-11-11 1:13 ` Thiago Farina
2012-11-11 5:54 ` Junio C Hamano
2012-11-11 11:11 ` suvayu ali
2012-11-11 12:02 ` Nguyen Thai Ngoc Duy
2012-11-11 12:14 ` Felipe Contreras
2012-11-11 13:09 ` Thiago Farina
2012-11-11 13:40 ` Felipe Contreras
2012-11-11 17:14 ` Krzysztof Mazur
2012-11-11 21:15 ` David Lang [this message]
2012-11-12 0:35 ` Deniz Türkoglu
2012-11-12 0:43 ` David Lang
2012-11-13 13:38 ` Nguyen Thai Ngoc Duy
2012-11-11 1:28 ` Deniz Türkoglu
2012-11-11 12:24 ` Felipe Contreras
2012-11-11 7:26 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1211111313140.19687@nftneq.ynat.uz \
--to=david@lang.hm \
--cc=deniz@spotify.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=krzysiek@podlesie.net \
--cc=sop@google.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).