From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Lang <david@lang.hm>
Subject: Re: Reviews on mailing-list
Date: Sun, 11 Nov 2012 13:15:08 -0800 (PST)
Message-ID: <alpine.DEB.2.02.1211111313140.19687@nftneq.ynat.uz>
References: <CA+ZXwZOnZZyk_KWmLLLNChWb1R_Av1s5jM4PsLFWKaG8BB+uXQ@mail.gmail.com> <CAMP44s2AvaAs-dn_eoSFWoLHBQk5QrrV=zYTOpRi2nEywoua4w@mail.gmail.com> <CACnwZYekU0CYnqQT8L2siJbUsn=T9qowgth94TWc8KN472Ziag@mail.gmail.com> <CAMP44s2P-nhAGgj9nuJ3cKqb6+enAthwiUNS8QTZn8MP1poJ2g@mail.gmail.com>
 <CACnwZYfP4=Fvt8T0GOEzjTOaEyYF_Ao6e_f02eqO_5_DyzM0Zw@mail.gmail.com> <20121111171451.GA26695@shrek.podlesie.net>
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Thiago Farina <tfransosi@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	=?ISO-8859-15?Q?Deniz_T=FCrkoglu?= <deniz@spotify.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Shawn Pearce <sop@google.com>
To: Krzysztof Mazur <krzysiek@podlesie.net>
X-From: git-owner@vger.kernel.org Sun Nov 11 22:16:11 2012
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1TXet0-00058T-Kh
	for gcvg-git-2@plane.gmane.org; Sun, 11 Nov 2012 22:16:10 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751754Ab2KKVP5 (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sun, 11 Nov 2012 16:15:57 -0500
Received: from mail.lang.hm ([64.81.33.126]:57844 "EHLO bifrost.lang.hm"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750781Ab2KKVP4 (ORCPT <rfc822;git@vger.kernel.org>);
	Sun, 11 Nov 2012 16:15:56 -0500
Received: from asgard.lang.hm (asgard.lang.hm [10.0.0.100])
	by bifrost.lang.hm (8.13.4/8.13.4/Debian-3) with ESMTP id qABLFlBL021720;
	Sun, 11 Nov 2012 13:15:47 -0800
X-X-Sender: dlang@asgard.lang.hm
In-Reply-To: <20121111171451.GA26695@shrek.podlesie.net>
User-Agent: Alpine 2.02 (DEB 1266 2009-07-14)
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/209448>

On Sun, 11 Nov 2012, Krzysztof Mazur wrote:

> On Sun, Nov 11, 2012 at 11:09:36AM -0200, Thiago Farina wrote:
>> On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras
>> <felipe.contreras@gmail.com> wrote:
>>> Requiring everyone to use a web browser would limit the amount of ways
>>> people can review patches.
>> I don't see that as a limitation as I think everyone has access to a
>> web browser these days, don't have?
>
> Almost everyone, but not everyone likes using web browser.

Using a web browser requires connectivity at the time you are doing the review.

Mailing list based reviews can be done at times when you don't have 
connectivity.

Coincidently, one of the common times when people don't have connectivity is 
when they are traveling, and this can be a good time to do things like code 
review.

David Lang