From: Felipe Contreras <felipe.contreras@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: "Deniz Türkoglu" <deniz@spotify.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Shawn Pearce" <sop@google.com>
Subject: Re: Reviews on mailing-list
Date: Sun, 11 Nov 2012 13:14:43 +0100 [thread overview]
Message-ID: <CAMP44s2P-nhAGgj9nuJ3cKqb6+enAthwiUNS8QTZn8MP1poJ2g@mail.gmail.com> (raw)
In-Reply-To: <CACnwZYekU0CYnqQT8L2siJbUsn=T9qowgth94TWc8KN472Ziag@mail.gmail.com>
On Sun, Nov 11, 2012 at 2:13 AM, Thiago Farina <tfransosi@gmail.com> wrote:
> On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras
>> Personally I think reviews on the mailing list is far superior than
>> any other review methods. I've even blogged about it and all the
>> reasons[1]. Gerrit is better than bugzilla, but it still requires a
>> web browser, and logging in.
>>
> Requiring a web browser is a huge requirement, ham??
Yes. Today people can use any mail interface: web, console-based,
graphical. They can use Gmail clients in their phone, or IMAP, or
whatever.
Requiring everyone to use a web browser would limit the amount of ways
people can review patches. Also, not everyone has javascript enabled
in their browser (I assume Gerrit needs that).
> How come that can
> be an impediment to move forward way of this awkward way of reviewing
> patches through email?
It's not awkward, it's the most sensible way.
You just replied to my mail the same way I would reply to a patch.
> Switching to Gerrit would mean everyone would
> be using the same tool instead of anyone using its own email client
> (gmail, mutt, thunderbird, whatever...)
Yes, that's bad.
> and having to figure out git
> format-patch, git send-email (--reply-to where?).
No need to figure anything.
% git config sendemail.to git@vger.kernel.org
% git send-email @{upstream}..
Done.
> There are a lot of issues of having to use email for reviewing patches
> that I think Gerrit is a superior alternative.
There are no issues. It works for Linux, qemu, libav, ffmpeg, git, and
many other projects.
> And many people are arguing for it!
Nope, they are not.
--
Felipe Contreras
next prev parent reply other threads:[~2012-11-11 12:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 23:19 Reviews on mailing-list Deniz Türkoglu
2012-11-10 23:40 ` Felipe Contreras
2012-11-11 1:13 ` Thiago Farina
2012-11-11 5:54 ` Junio C Hamano
2012-11-11 11:11 ` suvayu ali
2012-11-11 12:02 ` Nguyen Thai Ngoc Duy
2012-11-11 12:14 ` Felipe Contreras [this message]
2012-11-11 13:09 ` Thiago Farina
2012-11-11 13:40 ` Felipe Contreras
2012-11-11 17:14 ` Krzysztof Mazur
2012-11-11 21:15 ` David Lang
2012-11-12 0:35 ` Deniz Türkoglu
2012-11-12 0:43 ` David Lang
2012-11-13 13:38 ` Nguyen Thai Ngoc Duy
2012-11-11 1:28 ` Deniz Türkoglu
2012-11-11 12:24 ` Felipe Contreras
2012-11-11 7:26 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2P-nhAGgj9nuJ3cKqb6+enAthwiUNS8QTZn8MP1poJ2g@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=deniz@spotify.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sop@google.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).