From: Felipe Contreras <felipe.contreras@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: "Deniz Türkoglu" <deniz@spotify.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Shawn Pearce" <sop@google.com>
Subject: Re: Reviews on mailing-list
Date: Sun, 11 Nov 2012 14:40:48 +0100 [thread overview]
Message-ID: <CAMP44s2s9qL_ytb3vvrh02M0zWXyrE2Mt25bBi4Y_+Ur=5C4TA@mail.gmail.com> (raw)
In-Reply-To: <CACnwZYfP4=Fvt8T0GOEzjTOaEyYF_Ao6e_f02eqO_5_DyzM0Zw@mail.gmail.com>
On Sun, Nov 11, 2012 at 2:09 PM, Thiago Farina <tfransosi@gmail.com> wrote:
> On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> Requiring everyone to use a web browser would limit the amount of ways
>> people can review patches.
> I don't see that as a limitation as I think everyone has access to a
> web browser these days, don't have?
>
>>> How come that can
>>> be an impediment to move forward way of this awkward way of reviewing
>>> patches through email?
>>
>> It's not awkward, it's the most sensible way.
>>
> The most harder way I think?
>
> Look at this:
> https://gerrit.chromium.org/gerrit/#/q/status:open+project:chromiumos/platform/power_manager,n,z
>
> There I can go and see many informations that through this mailing
> list I can't or have to do much more work in order to archive this.
That information has nothing to do with reviews. That's patch state-tracking.
> If you open one of the 'patches' you can see some relevant information:
> - Who is the owner/author
> - Was it verified?
> - Is it ready for landing?
Irrelevant for git.
> - If I click on Side-by-side I get a nice diff view interface that
> plan text email does NOT give me.
Not useful.
> - Was it reviewed/approved (+1, +2)?
You can see the same in a mail thread.
> - It can be merged by one click.
Irrelevant for git.
> - The interface also provide the command line to download/apply the
> patch for me.
Not useful.
> - Isn't there a reason (implicit there) for Google being using tools
> like Gerrit/CodeReview(rietveld)/Mondrian for handling his code
> reviews rather than solely by 'email'?
Who knows And if there is, who knows if it's valid.
And none of those points has anything to do with code *review*.
All these points are about state-tracking, and that can be implemented
*on top* of the mailing list, for example through patchwork:
http://patchwork.newartisans.com/patch/1531/
That's if somebody actually cared about that, but that doesn't seem to
be the case.
>> You just replied to my mail the same way I would reply to a patch.
>>
> I replied through a web browser by the Gmail interface. ;)
Indeed, Gmail is one of the many ways you can review a patch.
You clik reply, you add the comments in line, and click send. Couldn't
be easier.
>>> There are a lot of issues of having to use email for reviewing patches
>>> that I think Gerrit is a superior alternative.
>>
>> There are no issues. It works for Linux, qemu, libav, ffmpeg, git, and
>> many other projects.
>>
>>> And many people are arguing for it!
>>
>> Nope, they are not.
>>
> If they weren't then nobody would be suggesting to use Gerrit for
> handling the review of git patches.
Except you, of course.
> But I think the big resistance comes from the fact that the core
> developers handle/review the git patches through Gnus/Emacs, so that
> is enough for them and they don't want to make the switch because of
> that?
gnus/emacs/notmuch/thunderbird/Gmail, and pretty much every mail
client out there.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2012-11-11 13:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 23:19 Reviews on mailing-list Deniz Türkoglu
2012-11-10 23:40 ` Felipe Contreras
2012-11-11 1:13 ` Thiago Farina
2012-11-11 5:54 ` Junio C Hamano
2012-11-11 11:11 ` suvayu ali
2012-11-11 12:02 ` Nguyen Thai Ngoc Duy
2012-11-11 12:14 ` Felipe Contreras
2012-11-11 13:09 ` Thiago Farina
2012-11-11 13:40 ` Felipe Contreras [this message]
2012-11-11 17:14 ` Krzysztof Mazur
2012-11-11 21:15 ` David Lang
2012-11-12 0:35 ` Deniz Türkoglu
2012-11-12 0:43 ` David Lang
2012-11-13 13:38 ` Nguyen Thai Ngoc Duy
2012-11-11 1:28 ` Deniz Türkoglu
2012-11-11 12:24 ` Felipe Contreras
2012-11-11 7:26 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s2s9qL_ytb3vvrh02M0zWXyrE2Mt25bBi4Y_+Ur=5C4TA@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=deniz@spotify.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sop@google.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).