From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Calbabreaker <calbabreaker@gmail.com>, git@vger.kernel.org
Subject: Re: Memory leak with sparse-checkout
Date: Wed, 22 Sep 2021 15:37:05 -0400 [thread overview]
Message-ID: <YUuF4SKO4lA/xLKZ@nand.local> (raw)
In-Reply-To: <98bd3b94-eb8d-b074-b89d-d86dcefaa995@gmail.com>
On Wed, Sep 22, 2021 at 03:16:22PM -0400, Derrick Stolee wrote:
> On 9/21/2021 4:45 PM, Taylor Blau wrote:
> [...]
> > I fear that we're talking about different things. With your patches, if
> > I munge my .git/info/sparse-checkout file, I can easily get something
> > like:
> >
> > $ git.compile sparse-checkout list
> > warning: unrecognized pattern: 'foo'
> > warning: disabling cone pattern matching
> >
> > to appear. But I'm wondering why the same doesn't happen when running
> > `git sparse-checkout init --cone` while the existing sparse-checkout
> > definition contains non-cone mode entries.
>
> You don't get that warning because it's not trying to parse the
> previous patterns using cone mode. Before my series, you would get
> the warning in a _second_ run of "git sparse-checkout init --cone".
OK. I was confused because in [1] you said that we produce this error
any time we try to load the existing definitions and parse them in
cone-mode.
I would have assumed that we would try to do that during `init --cone`
to read the existing sparse-checkout definition.
Thanks,
Taylor
[1]: https://lore.kernel.org/git/734ecf93-e563-20d5-7cf1-74048aa74d56@gmail.com/
prev parent reply other threads:[~2021-09-22 19:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:15 Memory leak with sparse-checkout Calbabreaker
2021-09-20 15:52 ` Taylor Blau
2021-09-20 16:29 ` Derrick Stolee
2021-09-20 16:42 ` Taylor Blau
2021-09-20 17:25 ` Derrick Stolee
2021-09-20 17:27 ` Derrick Stolee
2021-09-20 19:08 ` Taylor Blau
2021-09-20 20:56 ` Derrick Stolee
2021-09-20 21:20 ` Taylor Blau
2021-09-21 12:55 ` Derrick Stolee
2021-09-21 16:32 ` Taylor Blau
2021-09-21 18:56 ` Derrick Stolee
2021-09-21 20:45 ` Taylor Blau
2021-09-22 19:16 ` Derrick Stolee
2021-09-22 19:37 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUuF4SKO4lA/xLKZ@nand.local \
--to=me@ttaylorr.com \
--cc=calbabreaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).