From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,
Calbabreaker <calbabreaker@gmail.com>,
git@vger.kernel.org
Subject: Re: Memory leak with sparse-checkout
Date: Tue, 21 Sep 2021 16:45:19 -0400 [thread overview]
Message-ID: <YUpEX7mmZ0WPvbYK@nand.local> (raw)
In-Reply-To: <3c9af4e9-f3db-99af-d875-fb11bc8a643e@gmail.com>
On Tue, Sep 21, 2021 at 02:56:01PM -0400, Derrick Stolee wrote:
> > I thought that it might have been related to your third patch to change
> > how bad patterns are detected. But I ran the following script after
> > applying each of your three patches individually:
> >
> > rm -fr repo
> > git init repo
> > cd repo
> >
> > git sparse-checkout init
> > git sparse-checkout add foo
> > git sparse-checkout init --cone
> > git sparse-checkout add foo
> >
> > and the only difference is that we started silently dropping the bad
> > "foo" pattern after re-adding foo in cone-mode starting with the second
> > patch.
>
> In patch 2, we "detect" that the old patterns were not in cone mode
> because the core.sparseCheckoutCone config is false when parsing the
> patterns, so use_cone_patterns is 0.
I fear that we're talking about different things. With your patches, if
I munge my .git/info/sparse-checkout file, I can easily get something
like:
$ git.compile sparse-checkout list
warning: unrecognized pattern: 'foo'
warning: disabling cone pattern matching
to appear. But I'm wondering why the same doesn't happen when running
`git sparse-checkout init --cone` while the existing sparse-checkout
definition contains non-cone mode entries.
I could be holding it wrong, but I was unsuccessful in getting a warning
out with the quoted script.
> Let's move the discussion to that thread so we can interleave the
> patches themselves.
Sure, if you want. I just found it easier to reply here since I can more
readily quote the things I want to respond to.
Thanks,
Taylor
next prev parent reply other threads:[~2021-09-21 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:15 Memory leak with sparse-checkout Calbabreaker
2021-09-20 15:52 ` Taylor Blau
2021-09-20 16:29 ` Derrick Stolee
2021-09-20 16:42 ` Taylor Blau
2021-09-20 17:25 ` Derrick Stolee
2021-09-20 17:27 ` Derrick Stolee
2021-09-20 19:08 ` Taylor Blau
2021-09-20 20:56 ` Derrick Stolee
2021-09-20 21:20 ` Taylor Blau
2021-09-21 12:55 ` Derrick Stolee
2021-09-21 16:32 ` Taylor Blau
2021-09-21 18:56 ` Derrick Stolee
2021-09-21 20:45 ` Taylor Blau [this message]
2021-09-22 19:16 ` Derrick Stolee
2021-09-22 19:37 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUpEX7mmZ0WPvbYK@nand.local \
--to=me@ttaylorr.com \
--cc=calbabreaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).