From: Taylor Blau <me@ttaylorr.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,
Calbabreaker <calbabreaker@gmail.com>,
git@vger.kernel.org
Subject: Re: Memory leak with sparse-checkout
Date: Mon, 20 Sep 2021 15:08:34 -0400 [thread overview]
Message-ID: <YUjcMu7Z094eaFRA@nand.local> (raw)
In-Reply-To: <b7ee5ff5-dfff-8d3f-36f6-b30daf2d71ec@gmail.com>
On Mon, Sep 20, 2021 at 01:27:25PM -0400, Derrick Stolee wrote:
> On 9/20/2021 1:25 PM, Derrick Stolee wrote:
> > On 9/20/2021 12:42 PM, Taylor Blau wrote:
> >> We would probably want to perform this check both during initialization,
> >> and when adding patterns in cone mode. It may also be worthwhile to
> >> check the validity of the cone before running 'list' or 'reapply', too.
> >
> > 'list' definitely seems like a good idea, since it is expecting different
> > output than the literal patterns when cone mode is enabled.
>
> I double-checked this to see how to fix this, and the 'list' subcommand
> already notices that the patterns are not in cone mode and reverts its
> behavior to writing all of the sparse-checkout file to stdout. It also
> writes warnings over stderr before that.
>
> There might not be anything pressing to do here.
Hmm. I think we'd probably want the same behavior for init and any other
commands which could potentially overwrite the contents of the
sparse-checkout file.
Those may already call list routines internally, in which case I agree
that this is already taken care of. But if not, then I think we should
match list's behavior in the new locations, too.
Thanks,
Taylor
next prev parent reply other threads:[~2021-09-21 2:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:15 Memory leak with sparse-checkout Calbabreaker
2021-09-20 15:52 ` Taylor Blau
2021-09-20 16:29 ` Derrick Stolee
2021-09-20 16:42 ` Taylor Blau
2021-09-20 17:25 ` Derrick Stolee
2021-09-20 17:27 ` Derrick Stolee
2021-09-20 19:08 ` Taylor Blau [this message]
2021-09-20 20:56 ` Derrick Stolee
2021-09-20 21:20 ` Taylor Blau
2021-09-21 12:55 ` Derrick Stolee
2021-09-21 16:32 ` Taylor Blau
2021-09-21 18:56 ` Derrick Stolee
2021-09-21 20:45 ` Taylor Blau
2021-09-22 19:16 ` Derrick Stolee
2021-09-22 19:37 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUjcMu7Z094eaFRA@nand.local \
--to=me@ttaylorr.com \
--cc=calbabreaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).