From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 391F01F8C8 for ; Wed, 22 Sep 2021 19:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237204AbhIVTii (ORCPT ); Wed, 22 Sep 2021 15:38:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbhIVTih (ORCPT ); Wed, 22 Sep 2021 15:38:37 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96AC2C061574 for ; Wed, 22 Sep 2021 12:37:07 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id q205so4935974iod.8 for ; Wed, 22 Sep 2021 12:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ttaylorr-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ziW7LaY2YrgfQTN6HmBg0Rt13PzX+CfBBcK17/Dsj/g=; b=m6lJsQNPYAMrnE04v4NW2y+lB/YQngPCwUkjzmeifFE5DN42OJumqd106SeOAHapVB 5NCmeoSGuygOUWw6rsP4aZoCP0pDeQ5N6373IZcpV5YOOIhem5yT/Du4G/EiLwoicuL2 f93WgRWfPE2ugETb85V0b6vMQjfXlmALnzx+xKXSnpH/ZFjItPdQbnzzqvEanPIYDq+8 p2gSTkO8cBwSojIbtoVTg8gvjbnGOkGyX3/Y/3ZNxSmt60j588A8GI06akvYUoHpSJmJ fYfEfnluTqTGlhxxZcwYDSmpZD02kvk+8KuKVF0J2HErtvIVjhziusyEM7AyxQh24mVo dz7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ziW7LaY2YrgfQTN6HmBg0Rt13PzX+CfBBcK17/Dsj/g=; b=ZAqGncM1oMIHYch2mxnAQ/3lvES1hYTtnAWwUExc6E471SKFbKHJncvPKmCD7pHzlq kQin7mfsdyKu9Zy2/TGdXjNnxcWq+EBFFybbag96PWAlJgx+Wj7rNUx8prMyfPWzdP63 Y0JV2POxwaMUE6nfHq6zIhSQu6ledhQmADCgy4rZ0E6pWR6NHvidub4rcUJueZecj6nN Zxms7wSxU7x3R3xHNthfWvfa1ElL3W7H8pZ+THyRWpDots2OIB4pITNCwDdmWQ6ZVrwB qovG39bFa3RA0/nXgStpDWAXFBO6cCUubV96DUUeCOUpTSffC/ykbUdagRRqL2vP3yZD NLdg== X-Gm-Message-State: AOAM533GVzulF1khmcPV/1THu7fIoE1ZUrdE4MKB2UnO+AXs6EEEyzY4 JU7MCqcm9naNkF7aP3PHGZbeKo7Phxj6cw== X-Google-Smtp-Source: ABdhPJyoxLzdhejesq9QlpPd8spwPiCl5FC1+mSbe49NVcOF9t2i8rk+2S1zY7Z7QHntIsZQrEXLKg== X-Received: by 2002:a6b:f301:: with SMTP id m1mr591497ioh.3.1632339426939; Wed, 22 Sep 2021 12:37:06 -0700 (PDT) Received: from localhost (104-178-186-189.lightspeed.milwwi.sbcglobal.net. [104.178.186.189]) by smtp.gmail.com with ESMTPSA id k4sm1447856ilc.10.2021.09.22.12.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 12:37:06 -0700 (PDT) Date: Wed, 22 Sep 2021 15:37:05 -0400 From: Taylor Blau To: Derrick Stolee Cc: Calbabreaker , git@vger.kernel.org Subject: Re: Memory leak with sparse-checkout Message-ID: References: <427c6d86-f123-035e-b0e6-4a21598ed111@gmail.com> <734ecf93-e563-20d5-7cf1-74048aa74d56@gmail.com> <3c9af4e9-f3db-99af-d875-fb11bc8a643e@gmail.com> <98bd3b94-eb8d-b074-b89d-d86dcefaa995@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <98bd3b94-eb8d-b074-b89d-d86dcefaa995@gmail.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Sep 22, 2021 at 03:16:22PM -0400, Derrick Stolee wrote: > On 9/21/2021 4:45 PM, Taylor Blau wrote: > [...] > > I fear that we're talking about different things. With your patches, if > > I munge my .git/info/sparse-checkout file, I can easily get something > > like: > > > > $ git.compile sparse-checkout list > > warning: unrecognized pattern: 'foo' > > warning: disabling cone pattern matching > > > > to appear. But I'm wondering why the same doesn't happen when running > > `git sparse-checkout init --cone` while the existing sparse-checkout > > definition contains non-cone mode entries. > > You don't get that warning because it's not trying to parse the > previous patterns using cone mode. Before my series, you would get > the warning in a _second_ run of "git sparse-checkout init --cone". OK. I was confused because in [1] you said that we produce this error any time we try to load the existing definitions and parse them in cone-mode. I would have assumed that we would try to do that during `init --cone` to read the existing sparse-checkout definition. Thanks, Taylor [1]: https://lore.kernel.org/git/734ecf93-e563-20d5-7cf1-74048aa74d56@gmail.com/