From: "Alejandro R. Sedeño" <asedeno@mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
"Aleajndro R Sedeño" <asedeno@google.com>,
git@vger.kernel.org
Subject: Re: [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+
Date: Wed, 5 Oct 2022 18:22:38 -0400 [thread overview]
Message-ID: <CAOO-Oz1gQJJDiweWjeJAKq1ooVDwH629sXUAGPRd=efxJHK6yA@mail.gmail.com> (raw)
In-Reply-To: <xmqqilkynd91.fsf@gitster.g>
Sorry for the subject line change; I had hoped that --in-reply-to
would get it threaded properly and wanted to trim it down a bit.
-> "[PATCH] git-compat-util.h: GCC deprecated message arg only in GCC 4.5+"
-Alejandro
On Wed, Oct 5, 2022 at 5:59 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > On 2022-10-03 at 21:23:18, Aleajndro R Sedeño wrote:
> >> From: Alejandro R. Sedeño <asedeno@mit.edu>
> >>
> >> Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu>
> >> Signed-off-by: Alejandro R Sedeño <asedeno@google.com>
> >
> > It might be helpful to explain what system you're targeting when you see
> > this. CentOS 7 has GCC 4.8, and I'm not aware of any systems with an
> > older compiler receiving publicly available updates still. We've fairly
> > recently only been testing and targeting GCC 4.8 for that reason.
>
> I do agree with you that an update to give "why" in the proposed log
> message would be very welcome, e.g. "Even though such an ancient
> compiler may not matter much in real life, a workaround is simple
> enough." or something along that line.
>
> As to the change in the patch, I think it is good.
>
> Thanks, all. Expecting an updated version which hopefully would
> become the final version ;-)
>
>
next prev parent reply other threads:[~2022-10-05 22:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:23 [PATCH] git-compat-util.h: GCC deprecated only takes a message in GCC 4.5+ Aleajndro R Sedeño
2022-10-03 22:25 ` brian m. carlson
2022-10-03 23:45 ` Alejandro R. Sedeño
2022-10-05 14:53 ` Jeff King
2022-10-06 7:29 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:16 ` Jeff King
2022-10-06 21:15 ` Ævar Arnfjörð Bjarmason
2022-10-11 0:22 ` Jeff King
[not found] ` <xmqqilkynd91.fsf@gitster.g>
2022-10-05 22:19 ` [PATCH] git-compat-util.h: GCC deprecated message arg only " Aleajndro R Sedeño
2022-10-06 7:31 ` Ævar Arnfjörð Bjarmason
2022-10-06 12:24 ` Alejandro R. Sedeño
2022-10-05 22:22 ` Alejandro R. Sedeño [this message]
2022-10-06 7:33 ` [PATCH] git-compat-util.h: GCC deprecated only takes a message " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOO-Oz1gQJJDiweWjeJAKq1ooVDwH629sXUAGPRd=efxJHK6yA@mail.gmail.com' \
--to=asedeno@mit.edu \
--cc=asedeno@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).